Skip to content

Refactor/#006 페이지 리페인트 최적화 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 22, 2025
Merged

Refactor/#006 페이지 리페인트 최적화 #13

merged 6 commits into from
Jan 22, 2025

Conversation

@Ludovico7
Copy link
Collaborator

@Ludovico7 Ludovico7 commented Jan 20, 2025 •
edited
Loading

📝 변경 사항

Notion

🔍 변경 사항 설명

  • transform 속성을 hover시 실행하지 않고 컴포넌트가 생성될 때 실행하도록 수정했습니다.

🙏 질문 사항

📷 스크린샷 (선택)

  • UI 변경이 있는 경우 스크린샷이나 GIF를 첨부합니다.

✅ 작성자 체크리스트

  • Self-review: 코드가 스스로 검토됨
  • Unit tests 추가 또는 수정
  • 로컬에서 모든 기능이 정상 작동함
  • 린터 및 포맷터로 코드 정리됨
  • 의존성 업데이트 확인
  • 문서 업데이트 또는 주석 추가 (필요 시)

@Ludovico7 Ludovico7 added Refactor refactor codes FE Front End labels Jan 20, 2025
@Ludovico7 Ludovico7 self-assigned this Jan 20, 2025
@Ludovico7 Ludovico7 changed the title Refactor/페이지 리페인트 최적화 Refactor/#006페이지 리페인트 최적화 Jan 20, 2025
@Ludovico7 Ludovico7 changed the title Refactor/#006페이지 리페인트 최적화 Refactor/#006 페이지 리페인트 최적화 Jan 20, 2025
@hyonun321
Copy link
Collaborator

hyonun321 commented Jan 21, 2025

혹시 페이지 컨트롤 버튼이 어떤걸까요?
페이지 요소에 마우스를 다 호버해봤는데 찾지 못해서요..😥

dvsd
저는 페이지의 editor에 focus가 잡히면 전체가 리렌더링되네요

@Ludovico7
Copy link
Collaborator Author

Ludovico7 commented Jan 21, 2025

페이지 최대화, 최소화 버튼 있는 3개 버튼 있는 컴포넌트입니다!

혹시 렌더링 확인하실때 devtool에서 어떤 기능을 사용하시나요?

@hyonun321
Copy link
Collaborator

hyonun321 commented Jan 21, 2025

image

https://chromewebstore.google.com/detail/react-developer-tools/fmkadmapgofadopljbjfkapdkoienihi?hl=ko
를 사용했습니다 !

minjungw00
minjungw00 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@minjungw00 minjungw00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다!

hyonun321
hyonun321 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@hyonun321 hyonun321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 전달받았습니다

@github-actions github-actions bot merged commit c99dd8e into dev Jan 22, 2025
5 checks passed
pipisebastian
pipisebastian approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@pipisebastian pipisebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minjungw00 minjungw00 minjungw00 approved these changes

@pipisebastian pipisebastian pipisebastian approved these changes

@hyonun321 hyonun321 hyonun321 approved these changes

Assignees

@Ludovico7 Ludovico7

Labels

FE Front End Refactor refactor codes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ludovico7 @hyonun321 @minjungw00 @pipisebastian