Prefer static constexpr bool over std::true_type or std::false_type #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonesmz
force-pushed
the
prefer-bool-over-integral-constant
branch
from
697fb53 to
3caf754
Compare
jonesmz
force-pushed
the
prefer-bool-over-integral-constant
branch
from
3caf754 to
2f28096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over using std::true_type or std::false_type.
While the std::integral_constant derivatives aren't particularly heavy weight, they still add up in a codebase that sees them used in many places. Directly using static constexpr bool variables should reduce the number of template instantiations required, reducing build times.