-
Notifications
You must be signed in to change notification settings - Fork 21
[V3] Add Venmo install check #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -58,5 +58,9 @@ | |||
<string>UIInterfaceOrientationLandscapeLeft</string> | |||
<string>UIInterfaceOrientationLandscapeRight</string> | |||
</array> | |||
<key>LSApplicationQueriesSchemes</key> | |||
<array> | |||
<string>com.venmo.touch.v2</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this out as a requirement in the README and/or a migration guide if we have one? This check won't work unless merchants register this scheme. Can also add this in the CHANGELOG since it's new functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, i also attached a couple of screenshots
@@ -15,6 +16,8 @@ struct PopupBridgeUserScript { | |||
return '\(scheme)://\(host)/'; | |||
}; | |||
|
|||
window.popupBridge.isVenmoInstalled = \(isVenmoInstalled.description); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always find .description
a bit of a weird way to represent a string bool. Thoughts on just doing "\(isVenmoInstalled)"
here? Take it or leave it, may just be a me problem. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x2, thanks for the feedback, updated: fdbb9db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Summary of changes
README:

Migration guide:

Checklist
Authors