Merge V3 feature branch into Main #80

richherrera · 2025-03-24T17:03:58Z

Summary of changes

Pop-up Bridge Revamp

Checklist

~~[ ] Added a changelog entry~~

Authors

@richherrera @jaxdesmarais

* Bump up to swift 5.10 * Update workflows to use xCode 16 * Update README * Add v3 Migration guide * Add CHANGELOG entry * Fix workflow xcode path

* Convert Objc classes into Swift classes * Remove blank space

* Convert POPViewController to Swift * Rename ViewController * Address PR comments

* Update package.swift * Update podfile * Update pbxproj s * Update popspec * Change deployment target to 16.0 * Add CHANGELOG entry * Update README * Update migration guide * Rever podfile changes * Bump deployment target to ios 16 * Update SPM demo test example

* Add prefersEphemeralWebBrowserSession property to WebAuthenticationSession * Add prefersEphemeralWebBrowserSession to the POPPopupBridge initializer * Add CHANGELOG entry

* Add FPTIBatchData structure * Keys sorted by name * Add Bundle extension to expose BundleShortVersion * Define clientSDKVersion tag

* Update UTs to compare dictionaries instead of strings * Update UI Tests timeout to 10

* Add FPTIBatchData structure * Keys sorted by name * Add Bundle extension to expose BundleShortVersion * Define clientSDKVersion tag * Add PopupBridgeAnalytics enum

* Add venmo scheme to the allowlist in info.plist. * Add URLOpenet protocol and uiapplication extension * Add Venmo installed validation and pass it to the user script. * Add docstring * Use internal instead of static * Remove bool description * Update CHANGELOG * Update README * Update V3 migration guide

* Change FPTIBatchData structure * Add NetworkClient and AnalyticsServices files * Add Sessionable and NetworkError files * Add Network errors * Add Sessionable Protocol and Extension * Sort files * Add NetworkClient * Implement AnalyticsService class * Add Private Mark * Add necessary files (TestPlan, mock files and UT files) * Setup Test Plan * Create MockSession class and NonEncodable structure * Add NetworkClient tests * Create MockNetworkClient class * Sort files * Add missing blank space * Add UTs to test success and failures * Remove iOS 15 validation * Add analytics calls * Set sessionID value * Add AnalyticsService property * Add MockAnalyticsService * Fix PopupBridge tests adding mock * Increase time interval * Add MockAnalyticsService * Add PopupBrdige UTs * Strongly type FPTIBatchData * Add catch block * Update Sources/PopupBridge/FPTIBatchData.swift Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com> * Add analytics folder * Remove test plan * Address feedback * Sort files --------- Co-authored-by: Jax DesMarais-Leder <jdesmarais@paypal.com>

* Use weak self in closure * Remove scriptHandlers * Add WebViewScriptHandler * Avoid retain cycle using WebViewScriptHandler * Fix UTs * Add assert memory leak * Add trackForMemoryLeaks method * Fix file * Add test

* Update README * Fix typo * Add brackets * Update README * Add Venmo and PayPal examples * Update PayPal SDK reference

CHANGELOG.md

README.md

Sources/PopupBridge/Analytics/AnalyticsService.swift

CHANGELOG.md

sarahkoop · 2025-03-31T16:01:47Z

README.md

+You must add the following to the queries schemes allowlist in your app's info.plist:
+
+``` xml
+<key>LSApplicationQueriesSchemes</key>
+<array>
+  <string>com.venmo.touch.v2</string>
+</array>


Is this only required for Venmo integrations or any popup bridge use?

only required for Venmo

sarahkoop · 2025-03-31T16:02:55Z

README.md

+  // if popup bridge is detected, we set the deepLinkReturnUrl param
+  // so that the Venmo app knows to app switch back to the app hosting
+  // the webview, instead of the url inside of the webview
+  createOptions.deepLinkReturnUrl = window.popupBridge.getReturnUrlPrefix();
+
+  // the Braintree SDK is waiting for the hash in the url to change,
+  // normally the Venmo app switches back to the window and updates
+  // the hash along with it, but since we're instructing Venmo to
+  // return to the app that _hosts_ the webview via the specified
+  // deep link return url, we have to manually update the hash of
+  // the webview's url with the hash popup bridge receives from
+  // the Venmo app upon completion


The comments here are helpful for us but they seem like leaking internal functionality to be part of public README. What do you think?

you're right, updated: ac63134 what do you think?

Co-authored-by: Sarah Koop <skoop@paypal.com>

sarahkoop · 2025-03-31T16:03:41Z

README.md

+| 3.x.x | Active | April 2025 | TBA | TBA |
+| 2.x.x | Inactive | October 2023 | April 2025 | April 2026 |


If we plan to release today should these be March?

we could wait until tomorrow when it's April 🤔

April from previous comment: #77 (comment)

README.md

Co-authored-by: Sarah Koop <skoop@paypal.com>

richherrera and others added 13 commits February 4, 2025 11:52

[v3] Require xCode 16 (#67)

a7e11a9

* Bump up to swift 5.10 * Update workflows to use xCode 16 * Update README * Add v3 Migration guide * Add CHANGELOG entry * Fix workflow xcode path

[v3] Convert AppDelegate & SceneDelegate to Swift (#68)

313e878

* Convert Objc classes into Swift classes * Remove blank space

[v3] Convert POPViewController to Swift (#69)

a233d3a

* Convert POPViewController to Swift * Rename ViewController * Address PR comments

Merge branch 'main' into v3

aadfdd9

[V3] Expose prefersEphemeralWebBrowserSession (#71)

db864f0

* Add prefersEphemeralWebBrowserSession property to WebAuthenticationSession * Add prefersEphemeralWebBrowserSession to the POPPopupBridge initializer * Add CHANGELOG entry

[V3] Add FPTIBatchData model for events (#72)

a9ef086

* Add FPTIBatchData structure * Keys sorted by name * Add Bundle extension to expose BundleShortVersion * Define clientSDKVersion tag

[V3] Fix Unit & UI Tests (#74)

6f4a2f8

* Update UTs to compare dictionaries instead of strings * Update UI Tests timeout to 10

[V3] Add PopupBridgeAnalytics enum (#73)

bd272ef

* Add FPTIBatchData structure * Keys sorted by name * Add Bundle extension to expose BundleShortVersion * Define clientSDKVersion tag * Add PopupBridgeAnalytics enum

Bump cocoapods version in podfile.lock (#76)

7c9305d

[V3] Fix Retain Cycles (#79)

c08da20

* Use weak self in closure * Remove scriptHandlers * Add WebViewScriptHandler * Avoid retain cycle using WebViewScriptHandler * Fix UTs * Add assert memory leak * Add trackForMemoryLeaks method * Fix file * Add test

richherrera added do not merge feature branch merge labels Mar 24, 2025

richherrera self-assigned this Mar 24, 2025

richherrera requested a review from a team as a code owner March 24, 2025 17:03

richherrera marked this pull request as draft March 24, 2025 17:04

[V3] Update README (#77)

7c6b3fd

* Update README * Fix typo * Add brackets * Update README * Add Venmo and PayPal examples * Update PayPal SDK reference

jaxdesmarais approved these changes Mar 31, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

Sources/PopupBridge/Analytics/AnalyticsService.swift Show resolved Hide resolved

richherrera marked this pull request as ready for review March 31, 2025 15:09

Address PR comments

9492482

sarahkoop reviewed Mar 31, 2025

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

sarahkoop reviewed Mar 31, 2025

View reviewed changes

Update CHANGELOG.md

aa815a8

Co-authored-by: Sarah Koop <skoop@paypal.com>

sarahkoop reviewed Mar 31, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

richherrera and others added 2 commits March 31, 2025 10:07

Update README.md

b844f2a

Co-authored-by: Sarah Koop <skoop@paypal.com>

Update README

ac63134

sarahkoop approved these changes Mar 31, 2025

View reviewed changes

richherrera merged commit 26a37cd into main Apr 1, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge V3 feature branch into Main #80

Merge V3 feature branch into Main #80

Uh oh!

richherrera commented Mar 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarahkoop Mar 31, 2025

Uh oh!

richherrera Mar 31, 2025

Uh oh!

sarahkoop Mar 31, 2025

Uh oh!

richherrera Mar 31, 2025

Uh oh!

sarahkoop Mar 31, 2025

Uh oh!

richherrera Mar 31, 2025

Uh oh!

richherrera Mar 31, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

		\| 3.x.x \| Active \| April 2025 \| TBA \| TBA \|
		\| 2.x.x \| Inactive \| October 2023 \| April 2025 \| April 2026 \|

Merge V3 feature branch into Main #80

Merge V3 feature branch into Main #80

Uh oh!

Conversation

richherrera commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Checklist

Authors

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sarahkoop Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

richherrera Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

sarahkoop Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

richherrera Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

sarahkoop Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

richherrera Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

richherrera Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

richherrera commented Mar 24, 2025 •

edited

Loading