uri regex fix #617
Open
uri regex fix #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the URI regex used to remove hashes from file paths in the ZAP scan output.
- Moved the csv import to the top of the file.
- Replaces the single URI hash regex with two distinct regexes for different hash patterns and adds logging for changed URIs.
Comments suppressed due to low confidence (2)
zap/src/scan.py:362
- [nitpick] Consider renaming 'URI_HASH_REGEX1' and 'URI_HASH_REGEX2' to more descriptive names (e.g., 'URI_HASH_REGEX' and 'INDEX_HASH_REGEX') to clearly indicate their intended uses.
URI_HASH_REGEX1 = re.compile(r"[-\.][a-zA-Z0-9]{8,9}(?![a-fA-F0-9])")
zap/src/scan.py:379
- Remove the debug print statement to avoid unnecessary console output; use logging if type information is needed for debugging.
print(type(r))
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same regex change as previous PR