Skip to content

Conversation

kmilo9999
Copy link
Contributor

Added Jaworski cell detection project in software content.

Copy link

github-actions bot commented Feb 7, 2025

Visit the preview URL for this PR (updated for commit b182421):

https://ccv-brown-edu--pr303-feat-add-cell-counte-prqpp295.web.app

(expires Wed, 19 Feb 2025 16:50:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e6225babbaf68dadb99b2906d33811740e5d15cb

@kmilo9999 kmilo9999 requested a review from eldu February 7, 2025 15:13
@kmilo9999 kmilo9999 changed the title Add jaworski cell seg project [Feat] Add jaworski cell seg project Feb 7, 2025
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the detail page is broken:
Screenshot 2025-02-11 at 10 02 00

Do you need to include the Jaworski collaboration and add it as a group to the software page?

@kmilo9999 kmilo9999 requested a review from hollandjg February 11, 2025 19:35
@kmilo9999
Copy link
Contributor Author

@hollandjg It is fixed. I needed to make my name in the project to match the one in people.yml.

@eldu eldu requested a review from digicosmos86 February 11, 2025 20:56
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@digicosmos86 digicosmos86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only thing I'd suggest is that we use "Unsupervised cell segmentation" instead of "automated cell detection". The latter is not machine learning vocabulary lol

@kmilo9999
Copy link
Contributor Author

I applied @digicosmos86 suggestion.

@mirestrepo
Copy link
Member

I think the description could be more specific. Instead of saying recognizing objects, say the type of cells you're detecting. Instead of saying deep learning methods, mention the specific methods. If you are addressing challenges (e.g tightly papecked or large variation of sizes) mention those. I think in the descriptions we want to convey our solutions with more technical details

@kmilo9999
Copy link
Contributor Author

@mirestrepo Check the new description. I got a bit of help though.

@mirestrepo
Copy link
Member

@mirestrepo Check the new description. I got a bit of help though.

oh yeah! now we sound like pros! 🚀

@kmilo9999 kmilo9999 merged commit d6578d4 into main Feb 13, 2025
12 checks passed
@kmilo9999 kmilo9999 deleted the feat-add-cell-counter branch February 13, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants