Skip to content

ci: test on many node versions #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

ci: test on many node versions #21

wants to merge 6 commits into from

Conversation

goto-bus-stop
Copy link
Member

Use ljharb's configs to test a wide range of node.js versions.

This module is probably in need of updates. A big reason for the module to exist is to target Node.js 0.8+. This setup will give some confidence going forward that all targets are actually supported.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may need to use the build config for the node tests since there's a build process, because babel doesn't work far back enough.

goto-bus-stop and others added 2 commits June 26, 2025 09:08
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@goto-bus-stop
Copy link
Member Author

It seemed like the prepare script "just worked" w/ these actions (it attempted to install, failed due to not working that far back, and reattempted with a newer node.js version).
Probably because of this:
https://github.com/ljharb/actions/blob/f610c162bd4f050abd31ab57ec92cdcf43a8a5be/node/install/command.sh#L132-L139
and a dependency somewhere in the tree can't be installed on earlier Node.js versions.

It's not great to rely on a dep coincidentally not being able to install, so I'll change it to not do that sometime today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants