From 4446b6273ed4b2687c90f7d6d633b24def85eac4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9e=20Kooi?= Date: Tue, 11 Apr 2023 10:19:42 +0200 Subject: [PATCH 1/6] ci: test on many node versions --- .github/workflows/node-aught.yml | 18 ++++++++++++++++++ .github/workflows/node-tens.yml | 18 ++++++++++++++++++ package.json | 6 ++++-- 3 files changed, 40 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/node-aught.yml create mode 100644 .github/workflows/node-tens.yml diff --git a/.github/workflows/node-aught.yml b/.github/workflows/node-aught.yml new file mode 100644 index 0000000..f3cddd8 --- /dev/null +++ b/.github/workflows/node-aught.yml @@ -0,0 +1,18 @@ +name: 'Tests: node.js < 10' + +on: [pull_request, push] + +jobs: + tests: + uses: ljharb/actions/.github/workflows/node.yml@main + with: + range: '< 10' + type: minors + command: npm run tests-only + + node: + name: 'node < 10' + needs: [tests] + runs-on: ubuntu-latest + steps: + - run: 'echo tests completed' diff --git a/.github/workflows/node-tens.yml b/.github/workflows/node-tens.yml new file mode 100644 index 0000000..b49ceb1 --- /dev/null +++ b/.github/workflows/node-tens.yml @@ -0,0 +1,18 @@ +name: 'Tests: node.js >= 10' + +on: [pull_request, push] + +jobs: + tests: + uses: ljharb/actions/.github/workflows/node.yml@main + with: + range: '>= 10' + type: minors + command: npm run tests-only + + node: + name: 'node >= 10' + needs: [tests] + runs-on: ubuntu-latest + steps: + - run: 'echo tests completed' diff --git a/package.json b/package.json index 8c39f3d..1e960c6 100644 --- a/package.json +++ b/package.json @@ -36,8 +36,10 @@ }, "scripts": { "lint": "standard", - "test": "node test", - "prepare": "npm run build && node test", + "pretest": "npm run build", + "tests-only": "node test", + "test": "npm run tests-only && npm run lint", + "prepare": "npm run build", "build:self": "babel src --out-dir .", "build": "npm-run-all --parallel build:*" }, From 423a1f7b77c880e05169fc82e3952728bd999b64 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9e=20Kooi?= Date: Wed, 25 Jun 2025 17:01:04 +0200 Subject: [PATCH 2/6] ci: use the configs from to-buffer --- .github/workflows/node-aught.yml | 2 +- .github/workflows/node-pretest.yml | 7 +++++++ .github/workflows/node-tens.yml | 11 +++++++---- .github/workflows/node-twenties.yml | 21 +++++++++++++++++++++ .github/workflows/rebase.yml | 9 +++++++++ .github/workflows/require-allow-edits.yml | 12 ++++++++++++ 6 files changed, 57 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/node-pretest.yml create mode 100644 .github/workflows/node-twenties.yml create mode 100644 .github/workflows/rebase.yml create mode 100644 .github/workflows/require-allow-edits.yml diff --git a/.github/workflows/node-aught.yml b/.github/workflows/node-aught.yml index f3cddd8..c49d417 100644 --- a/.github/workflows/node-aught.yml +++ b/.github/workflows/node-aught.yml @@ -15,4 +15,4 @@ jobs: needs: [tests] runs-on: ubuntu-latest steps: - - run: 'echo tests completed' + - run: true diff --git a/.github/workflows/node-pretest.yml b/.github/workflows/node-pretest.yml new file mode 100644 index 0000000..765edf7 --- /dev/null +++ b/.github/workflows/node-pretest.yml @@ -0,0 +1,7 @@ +name: 'Tests: pretest/posttest' + +on: [pull_request, push] + +jobs: + tests: + uses: ljharb/actions/.github/workflows/pretest.yml@main diff --git a/.github/workflows/node-tens.yml b/.github/workflows/node-tens.yml index b49ceb1..6b71d59 100644 --- a/.github/workflows/node-tens.yml +++ b/.github/workflows/node-tens.yml @@ -1,18 +1,21 @@ -name: 'Tests: node.js >= 10' +name: 'Tests: node.js 10 - 20' on: [pull_request, push] +permissions: + contents: read + jobs: tests: uses: ljharb/actions/.github/workflows/node.yml@main with: - range: '>= 10' + range: '>= 10 < 20' type: minors command: npm run tests-only node: - name: 'node >= 10' + name: 'node 10 - 20' needs: [tests] runs-on: ubuntu-latest steps: - - run: 'echo tests completed' + - run: true diff --git a/.github/workflows/node-twenties.yml b/.github/workflows/node-twenties.yml new file mode 100644 index 0000000..66c9382 --- /dev/null +++ b/.github/workflows/node-twenties.yml @@ -0,0 +1,21 @@ +name: 'Tests: node.js >= 20' + +on: [pull_request, push] + +permissions: + contents: read + +jobs: + tests: + uses: ljharb/actions/.github/workflows/node.yml@main + with: + range: '>= 20' + type: minors + command: npm run tests-only + + node: + name: 'node >= 20' + needs: [tests] + runs-on: ubuntu-latest + steps: + - run: true diff --git a/.github/workflows/rebase.yml b/.github/workflows/rebase.yml new file mode 100644 index 0000000..b9e1712 --- /dev/null +++ b/.github/workflows/rebase.yml @@ -0,0 +1,9 @@ +name: Automatic Rebase + +on: [pull_request_target] + +jobs: + _: + uses: ljharb/actions/.github/workflows/rebase.yml@main + secrets: + token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/require-allow-edits.yml b/.github/workflows/require-allow-edits.yml new file mode 100644 index 0000000..7b842f8 --- /dev/null +++ b/.github/workflows/require-allow-edits.yml @@ -0,0 +1,12 @@ +name: Require “Allow Edits” + +on: [pull_request_target] + +jobs: + _: + name: "Require “Allow Edits”" + + runs-on: ubuntu-latest + + steps: + - uses: ljharb/require-allow-edits@main From e11af4ba651913d49828fe36a94d38081755ed46 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9e=20Kooi?= Date: Wed, 25 Jun 2025 17:08:03 +0200 Subject: [PATCH 3/6] ci: delete legacy CI --- .github/workflows/ci.yml | 45 ---------------------------------------- 1 file changed, 45 deletions(-) delete mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml deleted file mode 100644 index 2bf495b..0000000 --- a/.github/workflows/ci.yml +++ /dev/null @@ -1,45 +0,0 @@ -name: CI - -on: [push, pull_request] - -jobs: - test: - name: Run tests - strategy: - matrix: - node-version: - - '0.12' - - '4.x' - - '6.x' - - '8.x' - - '10.x' - - '12.x' - - '14.x' - - '15.x' - runs-on: ubuntu-latest - steps: - - name: Checkout sources - uses: actions/checkout@v2 - - name: Install Node.js ${{matrix.node-version}} - uses: actions/setup-node@v2 - with: - node-version: ${{matrix.node-version}} - - name: Install dependencies - run: npm install - - name: Run tests - run: npm test - - lint: - name: Standard Style - runs-on: ubuntu-latest - steps: - - name: Checkout sources - uses: actions/checkout@v2 - - name: Install Node.js - uses: actions/setup-node@v2 - with: - node-version: 14.x - - name: Install dependencies - run: npm install - - name: Check style - run: npm run lint From d197552fe20041d50200c4904de5f5b6b0249c07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9e=20Kooi?= Date: Wed, 25 Jun 2025 17:09:03 +0200 Subject: [PATCH 4/6] pkg: configure engines field --- package.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package.json b/package.json index 1e960c6..5f50ea7 100644 --- a/package.json +++ b/package.json @@ -21,6 +21,9 @@ "standard": "^13.1.0", "tape": "^4.13.3" }, + "engines": { + "node": ">= 0.8" + }, "homepage": "https://github.com/browserify/acorn-node", "keywords": [ "acorn", From 4680c973b15488c26dd18f04d575d79f639b9ccc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9e?= Date: Thu, 26 Jun 2025 09:08:39 +0200 Subject: [PATCH 5/6] Fix the package scripts Co-authored-by: Jordan Harband --- package.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 5f50ea7..3c78ebf 100644 --- a/package.json +++ b/package.json @@ -39,9 +39,11 @@ }, "scripts": { "lint": "standard", - "pretest": "npm run build", + "pretest": "npm run lint", + "pretests-only": "npm run build", "tests-only": "node test", - "test": "npm run tests-only && npm run lint", + "test": "npm run tests-only", + "posttest": "npx npm@\">= 10.2\" audit --production", "prepare": "npm run build", "build:self": "babel src --out-dir .", "build": "npm-run-all --parallel build:*" From cf7d8df5fc11739e07beac606e26740e9184d536 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9e=20Kooi?= Date: Thu, 26 Jun 2025 09:18:13 +0200 Subject: [PATCH 6/6] minus pretests-only --- package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/package.json b/package.json index 3c78ebf..58f75ae 100644 --- a/package.json +++ b/package.json @@ -40,7 +40,6 @@ "scripts": { "lint": "standard", "pretest": "npm run lint", - "pretests-only": "npm run build", "tests-only": "node test", "test": "npm run tests-only", "posttest": "npx npm@\">= 10.2\" audit --production",