fix: settings refactor

Author: brunomikoski

Scripts/Editor/Core/CodeGenerationUtility.cs

@@ -307,17 +307,17 @@ public static void DisablePartialClassGenerationIfDisallowed(ScriptableObjectCol
                 SOCSettings.Instance.SetWriteAsPartialClass(collection, false);
             }
         }
-        public static bool CheckIfCanBePartial(ScriptableObjectCollection collection)
+        public static bool CheckIfCanBePartial(ScriptableObjectCollection collection, string destinationFolder = "")
         {
             string baseClassPath = AssetDatabase.GetAssetPath(MonoScript.FromScriptableObject(collection));
             string baseAssembly = CompilationPipeline.GetAssemblyNameFromScriptPath(baseClassPath);
-            string targetGeneratedCodePath = CompilationPipeline.GetAssemblyNameFromScriptPath(
-                AssetDatabase.GetAssetPath(SOCSettings.Instance.GetGeneratedScriptsParentFolder(collection)));
+            if(string.IsNullOrEmpty(destinationFolder))
+                destinationFolder = CompilationPipeline.GetAssemblyNameFromScriptPath(SOCSettings.Instance.GetParentFolderPathForCollection(collection));
 
             // NOTE: If you're not using assemblies for your code, it's expected that 'targetGeneratedCodePath' would
             // be the same as 'baseAssembly', but it isn't. 'targetGeneratedCodePath' seems to be empty in that case.
-            bool canBePartial = baseAssembly.Equals(targetGeneratedCodePath, StringComparison.Ordinal) ||
-                                string.IsNullOrEmpty(targetGeneratedCodePath);
+            bool canBePartial = baseAssembly.Equals(destinationFolder, StringComparison.Ordinal) ||
+                                string.IsNullOrEmpty(destinationFolder);
 
             return canBePartial;
         }
@@ -374,10 +374,10 @@ public static void GenerateStaticCollectionScript(ScriptableObjectCollection col
 
             string fileName = SOCSettings.Instance.GetStaticFilenameForCollection(collection);
             string nameSpace = SOCSettings.Instance.GetNamespaceForCollection(collection);
-            string finalFolder = AssetDatabase.GetAssetPath(SOCSettings.Instance.GetGeneratedScriptsParentFolder(collection));
+            string finalFolder = AssetDatabase.GetAssetPath(SOCSettings.Instance.GetParentDefaultAssetScriptsFolderForCollection(collection));
 
             bool writeAsPartial = SOCSettings.Instance.GetWriteAsPartialClass(collection);
-            bool useBaseClass = SOCSettings.Instance.GetUseBaseClassForITems(collection);
+            bool useBaseClass = SOCSettings.Instance.GetUseBaseClassForItem(collection);
 
 
             AssetDatabaseUtils.CreatePathIfDoesntExist(finalFolder);
@@ -620,7 +620,7 @@ private static void WriteNonAutomaticallyLoadedCollectionItems(ScriptableObjectC
         public static bool DoesStaticFileForCollectionExist(ScriptableObjectCollection collection)
         {
             return File.Exists(Path.Combine(
-                AssetDatabase.GetAssetPath(SOCSettings.Instance.GetGeneratedScriptsParentFolder(collection)),
+                AssetDatabase.GetAssetPath(SOCSettings.Instance.GetParentDefaultAssetScriptsFolderForCollection(collection)),
                 $"{SOCSettings.Instance.GetStaticFilenameForCollection(collection)}.g.cs"));
         }
     }

Scripts/Editor/Core/CollectionSettings.cs

@@ -0,0 +1,50 @@
+using System;
+using System.IO;
+using UnityEditor;
+
+namespace BrunoMikoski.ScriptableObjectCollections
+{
+    [Serializable]
+    public class CollectionSettings
+    {
+        public LongGuid Guid;
+        public string Namespace;
+        public string StaticFilename;
+        public string ParentFolderPath;
+        public bool WriteAsPartialClass;
+        public bool UseBaseClassForItems;
+        public bool EnforceIndirectAccess;
+
+        public CollectionSettings(ScriptableObjectCollection targetCollection)
+        {
+            Guid = targetCollection.GUID;
+            string targetNamespace = targetCollection.GetItemType().Namespace;
+            if (!string.IsNullOrEmpty(SOCSettings.Instance.NamespacePrefix))
+                targetNamespace = $"{SOCSettings.Instance.NamespacePrefix}";
+            
+            Namespace = targetNamespace;
+
+            if (!string.IsNullOrEmpty(SOCSettings.Instance.generatedScriptsDefaultFilePath))
+            {
+                ParentFolderPath = SOCSettings.Instance.generatedScriptsDefaultFilePath;
+            }
+            else
+            {
+                string baseClassPath = AssetDatabase.GetAssetPath(MonoScript.FromScriptableObject(targetCollection));
+                string parentFolder = Path.GetDirectoryName(baseClassPath);
+                ParentFolderPath = parentFolder;
+            }
+
+            bool canBePartial = CodeGenerationUtility.CheckIfCanBePartial(targetCollection, ParentFolderPath);
+            
+            if (!canBePartial)
+                StaticFilename = $"{targetCollection.GetType().Name}Static".FirstToUpper();
+            else 
+                StaticFilename = $"{targetCollection.GetType().Name}".FirstToUpper();
+
+            WriteAsPartialClass = canBePartial;
+            UseBaseClassForItems = false;
+            EnforceIndirectAccess = false;
+        }
+    }
+}