Skip to content

Conversation

mgroensmit
Copy link
Contributor

The 'getAvailableButtons' method can return a boolean (false) instead of an array.

I think the getAvailableButtons method should just return an empty array if there are no available buttons, but considering Hyrum's law I would consider that a breaking change requiring a minor version update. This Pull Request should be minimal impact, warranting a release in a patch-version.

@Buckaroo-Rene
Copy link
Contributor

Buckaroo-Rene commented Dec 2, 2024

Hi @mgroensmit,

Thank you for your message! Our team has addressed this issue in the following PR:
BP-3894

The fix will be included in our upcoming release.

@Buckaroo-Rene Buckaroo-Rene changed the title Update Applepay.php BP-3894 Update Applepay.php Dec 2, 2024
@Buckaroo-Rene Buckaroo-Rene self-assigned this Dec 2, 2024
@Buckaroo-Rene Buckaroo-Rene added 👏Thank You✨ Thank you for contributing! Status: Waiting for release This issue has been solved, but is not released yet. Priority: Normal This issue has a normal/medium priority. labels Dec 2, 2024
@Buckaroo-Rene Buckaroo-Rene added Status: Released A fix is included in a release already. and removed Status: Waiting for release This issue has been solved, but is not released yet. labels Jan 23, 2025
@Buckaroo-Rene
Copy link
Contributor

This is released in v1.51.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Normal This issue has a normal/medium priority. Status: Released A fix is included in a release already. 👏Thank You✨ Thank you for contributing!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants