Drop Python 3.8 support #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.8 is [EOL as of 2024-10-07][1]. This patch: * Drops support for Python 3.8 * Upgrades our syntax to 3.9 * Re-locks our deps to 3.9 Assuming we do this, our next release should be `v0.6`. Fixes #202. [1]: https://devguide.python.org/versions/#unsupported-versions
|
@akshayjshah not sure if you have a preference for our version support matrix for Python, but figured dropping an EOL version pre-v1 is reasonable. |
stefanvanburen
commented
Oct 28, 2024
| @@ -31,7 +31,6 @@ Issues = "https://github.com/bufbuild/protovalidate-python/issues" | |||
| source = "vcs" | |||
|
|
|||
| [tool.ruff] | |||
| target-version = "py38" | |||
There was a problem hiding this comment.
https://docs.astral.sh/ruff/settings/#target-version — this will use the requires-python version if not set; don't need to keep the separate setting.
rodaine
approved these changes
Oct 28, 2024
akshayjshah
reviewed
Oct 28, 2024
stefanvanburen
added a commit
that referenced
this pull request
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.8 is EOL as of 2024-10-07. This patch:
Assuming we do this, our next release should be
v0.6.Fixes #202.