Conversation
Collaborator
Android notifier sizes
Generated by 🚫 Danger |
tomlongridge
previously approved these changes
Feb 10, 2026
Contributor
tomlongridge
left a comment
There was a problem hiding this comment.
LGTM - changelog pending at release
… OOMs to be reported with the pre-allocated memory in the NDK
…s `unhandledException` in the NDK event serializer
…nto a Plugin so that the behaviour is opt-in
…veOutOfMemoryPlugin
…MemoryPlugin to the plugin instead of NativeBridge
…cxx-bugsnag scenarios to avoid dependency issues
… in a native on_error callback
…the same logic as OomScenario to burn memory
dca8232 to
00a75d0
Compare
tomlongridge
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Allow more customisation over
OutOfMemoryErrorhandling.Design
OutOfMemoryErrors are a complex case and can sometimes be under reported because our default error handling needs to allocate memory for theEventand all of its data.This PR introducing a new
OutOfMemoryHandlerwhich can either block or augment the default exception handling path before the SDK attempts to process anOutOfMemoryError. Thebugsnag-plugin-android-ndkmodule now includes a specialised path forOutOfMemoryHandlerthat can be enabled via a newNativeOutOfMemoryPluginChangeset
Client.outOfMemoryHandler(get/set) andBugsnag.outOfMemoryHandler(get/set)Throwable.anyCauseMatchesto avoid allocating an unrolled cause list when detecting discards andOutOfMemoryErrorsNativeOutOfMemoryPluginas new public API inbugsnag-plugin-android-ndkwhich will redirectOutOfMemoryErrors to the NDK layer for reporting through pre-allocated memoryTesting
New end-to-end tests