Skip to content

Commit 0c0fd2e

Browse files
author
djskinner
authored
Merge pull request #2141 from bugsnag/fix-electron-v8
Fix electron v8
2 parents 6118ca0 + 37b6b0d commit 0c0fd2e

File tree

6 files changed

+7
-24
lines changed

6 files changed

+7
-24
lines changed

test/electron/features/support/utils/payload-matchers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ const compareArray = (expected, actual, path) => {
6161
let found = 0 // counts matching indices and ensures ordering is correct
6262
const expectToFind = expected.length
6363
const keyPath = [path, '{index}'].join('.')
64-
let differences
64+
let differences = []
6565
for (const item of actual) {
6666
if (found === expectToFind) {
6767
break

test/electron/fixtures/app/src/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ function makeSimpleGetRequest (fail = false) {
5454
}
5555

5656
function networkRequestError () {
57-
const request = net.request('http://locahost:65536/')
57+
const request = net.request('http://locahost:994/')
5858
request.on('error', notify)
5959
request.end()
6060
}

test/electron/fixtures/events/main/breadcrumbs/network/error.json

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"timestamp": "{TIMESTAMP}",
6262
"metaData": {
6363
"method": "GET",
64-
"url": "http://locahost:65536/",
64+
"url": "http://locahost:994/",
6565
"status": "{TYPE:undefined}",
6666
"duration": "{TYPE:number}"
6767
}
@@ -71,13 +71,7 @@
7171
{
7272
"errorMessage": "something bad",
7373
"errorClass": "ReferenceError",
74-
"stacktrace": [{
75-
"file": "./src/errors.js",
76-
"lineNumber": 18,
77-
"code": {
78-
"1": "{TYPE:string}"
79-
}
80-
}],
74+
"stacktrace": [],
8175
"type": "electronnodejs"
8276
}
8377
]

test/electron/fixtures/events/main/breadcrumbs/network/get-failure.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,7 @@
7171
{
7272
"errorMessage": "something bad",
7373
"errorClass": "ReferenceError",
74-
"stacktrace": [{
75-
"file": "./src/errors.js",
76-
"lineNumber": 18,
77-
"code": {
78-
"1": "{TYPE:string}"
79-
}
80-
}],
74+
"stacktrace": [],
8175
"type": "electronnodejs"
8276
}
8377
]

test/electron/fixtures/events/main/breadcrumbs/network/get-success.json

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,7 @@
7171
{
7272
"errorMessage": "something bad",
7373
"errorClass": "ReferenceError",
74-
"stacktrace": [{
75-
"file": "./src/errors.js",
76-
"lineNumber": 18,
77-
"code": {
78-
"1": "{TYPE:string}"
79-
}
80-
}],
74+
"stacktrace": [],
8175
"type": "electronnodejs"
8276
}
8377
]

test/electron/local-npm-config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
storage: ../.verdaccio
2+
max_body_size: 25mb
23
auth:
34
htpasswd:
45
file: ../.verdaccio/htpasswd

0 commit comments

Comments
 (0)