Skip to content

[Integration] Typescript #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 434 commits into
base: next
Choose a base branch
from
Draft

[Integration] Typescript #2224

wants to merge 434 commits into from

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Oct 16, 2024 •
edited
Loading

Goal

Convert packages to TypeScript using rollup to bundle both ES modules and Common JS modules for maximum compatibility

Changeset

  • Install and configure rollup
  • Add type annotations to browser packages
  • Update build scripts to generate es modules

Testing

Covered by CI

Outstanding

  • Test tree shaking manually

@gingerbenw gingerbenw changed the title Convert packages to typescript and es modules Convert packages to TypeScript and ES Modules Oct 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 47.11 kB 14.09 kB
After 55.06 kB 16.54 kB
± ⚠️ +7,954 bytes ⚠️ +2,449 bytes

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against c90570d

@gingerbenw gingerbenw force-pushed the integration/typescript branch 2 times, most recently from 0b18a5e to 25ca84e Compare October 24, 2024 10:23
@gingerbenw gingerbenw changed the title Convert packages to TypeScript and ES Modules Modernise browser packages Oct 25, 2024
@gingerbenw gingerbenw force-pushed the integration/typescript branch from 4d6971c to eade9df Compare November 12, 2024 16:17
@gingerbenw gingerbenw force-pushed the integration/typescript branch from 9a4591e to 7bbbff9 Compare December 5, 2024 16:04
gingerbenw
gingerbenw commented Feb 3, 2025
View reviewed changes
packages/plugin-react/src/plugin.ts
error,
true,
handledState,
1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the signature for Event.create the errorFramesToSkip parameter should be the 5th - the 4th parameter should be for the component name

gingerbenw added 30 commits July 22, 2025 10:26
@gingerbenw
refactor: 🚚 move json-payload to standalone package
a824981
@gingerbenw
refactor: 🔥 remove unused @bugsnag/delivery-xml-http-request package
2081aa6 
remove package no longer required for browser delivery as IE8 and IE9 are no longer supported
@gingerbenw
refactor: 🔧 update rollup configuration to ensure smaller bundle size
f6dfa44
@gingerbenw
test: 🧪 skip webpack3 tests
234a6ef
@gingerbenw
refactor: 🔧 remove unsafe_comps option causing stacktrack file parsin…
bf82be0 
…g issue
@gingerbenw
fix chrome 43 compatibility
be18985
@gingerbenw
update treeshaking preset
54a12fb
@gingerbenw
additional bundle shrinkage
c8493a3
@gingerbenw
bump android tests to v8
9f0810e
@gingerbenw
additional shrinkage
74d4c2c
@gingerbenw
disable chrome 43 tests
4686991
@gingerbenw
disable angular 12 tests
be6f4c7
@gingerbenw
Revert "disable angular 12 tests"
514f14a 
This reverts commit be6f4c7.
@gingerbenw
use stylus version from github
ec28d5a
@gingerbenw
Revert "additional shrinkage"
902757a 
This reverts commit 74d4c2c.
@gingerbenw
resolve angular dependency
7aa795e
@gingerbenw
additional bundle shrinkage
eda561d
@gingerbenw
update bundle exports
60bc9f3
@gingerbenw
add missing notifiable error
d919051
@gingerbenw
update configuration
a137f6e
@gingerbenw
add android 8 error reference
1eefb25
@gingerbenw
update terser configuration
b5ebb60
@gingerbenw
make modues external
a89bae0
@gingerbenw
Merge branch 'next' into integration/typescript
1ac9077
@gingerbenw
disable IE11 tests
b22cfd5
@gingerbenw
update README
7286d28
@gingerbenw
Merge branch 'integration/typescript' into PLAT-13684/json-payload
6b4f022
@gingerbenw
remove unused rollup config
e480b88
@gingerbenw
Merge pull request #2496 from bugsnag/PLAT-13684/json-payload
1638ef8 
Optimise bundle size: json-payload
@gingerbenw
Merge pull request #2491 from bugsnag/PLAT-13605/update-linting-rules
c90570d 
Add linting rules to support TS 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gingerbenw @AnastasiiaSvietlova