Skip to content

Use registerPreloadScript for electron sessions #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 20, 2025
Merged

Use registerPreloadScript for electron sessions #2524

merged 7 commits into from
Aug 20, 2025

Conversation

gingerbenw
Copy link
Member

@gingerbenw gingerbenw commented Aug 15, 2025 •
edited
Loading

Goal

This PR refactors the Electron plugin to use the registerPreloadScript API instead of the deprecated setPreloads API when it is available for injecting Bugsnag's preload script into Electron sessions.

Design

Retain usage of setPreloads when registerPreloadScript is not available, for backwards compatibility

Changeset

  • Use session.registerPreloadScript when available, falling back to session.setPreloads
  • Fixes TypeScript export definitions in package.json

Testing

Covered by existing CI

gingerbenw and others added 3 commits August 15, 2025 11:13
@gingerbenw
refactor: ♻️ swap out deprecated setPreloads API for registerPreloadS…
1561d4b 
…cript
@mifi @gingerbenw
fix types
bd2e341 
if not i'm getting typescript errors when importing
@mifi @gingerbenw
Update package.json
55b178d 
fix also other exports
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 47.11 kB 14.09 kB
After 47.11 kB 14.09 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 055d3d6

@gingerbenw gingerbenw requested a review from Copilot August 15, 2025 12:16
Copilot

This comment was marked as resolved.

Sign in to view

@gingerbenw gingerbenw changed the title refactor: ♻️ swap out deprecated setPreloads API for registerP… Use registerPreloadScript for electron sessions Aug 15, 2025
@gingerbenw gingerbenw marked this pull request as ready for review August 15, 2025 14:18
@hannah-smartbear hannah-smartbear mentioned this pull request Aug 15, 2025
Open
@gingerbenw gingerbenw enabled auto-merge (squash) August 18, 2025 09:22
yousif-bugsnag
yousif-bugsnag approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@yousif-bugsnag yousif-bugsnag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gingerbenw gingerbenw merged commit 5e794bd into next Aug 20, 2025
21 checks passed
@gingerbenw gingerbenw deleted the gingerbenw/electron-fix branch August 20, 2025 09:26
@gingerbenw gingerbenw mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@yousif-bugsnag yousif-bugsnag yousif-bugsnag approved these changes

@lemnik lemnik Awaiting requested review from lemnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gingerbenw @yousif-bugsnag @mifi