Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Changelog

## [Unreleased]

### Changed

- (electron) Remove usage of deprecated `session.setPreloads` API [#2524](https://github.com/bugsnag/bugsnag-js/pull/2524)

### Fixed

- (plugin-electron-ipc) Fixed exports in `package.json` to improve TypeScript compatibility [#2524](https://github.com/bugsnag/bugsnag-js/pull/2524)

## [8.4.0] - 2025-06-18

### Added
Expand Down
18 changes: 15 additions & 3 deletions packages/electron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,21 @@
"version": "8.4.0",
"main": "src/notifier.js",
"exports": {
".": "./src/notifier.js",
"./main": "./src/client/main.js",
"./renderer": "./src/client/renderer.js"
".": {
"types": "./types/notifier.d.ts",
"default": "./src/notifier.js",
"import": "./src/notifier.js"
},
"./main": {
"types": "./types/notifier.d.ts",
"default": "./src/client/main.js",
"import": "./src/client/main.js"
},
"./renderer": {
"types": "./types/notifier.d.ts",
"default": "./src/client/renderer.js",
"import": "./src/client/renderer.js"
}
},
"types": "types/notifier.d.ts",
"description": "@bugsnag/electron notifier",
Expand Down
18 changes: 5 additions & 13 deletions packages/plugin-electron-ipc/electron-ipc.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,21 +34,13 @@ module.exports = {
}

const setPreload = () => {
const bugsnagPreload = resolve(__dirname, 'dist', 'preload.bundle.js')
const bugsnagPreloadPath = resolve(__dirname, 'dist', 'preload.bundle.js')

// for every session created, insert Bugsnag's preload script
app.on('session-created', session => {
// setPreloads replaces any existing value, so check the existing value first
const existingPreloads = session.getPreloads()
session.setPreloads([bugsnagPreload, ...existingPreloads])

// ensure our preload is never replaced with subsequent setPreloads calls
const setPreloads = session.setPreloads
session.setPreloads = (...args) => {
// if an invalid (non-array) parameter is passed, send it through to the
// original method to let that raise an error in the default way
if (!Array.isArray(args[0])) setPreloads.call(session, ...args)
setPreloads.call(session, [bugsnagPreload, ...args[0]])
}
session.registerPreloadScript({
type: 'frame',
filePath: bugsnagPreloadPath
})
})
}