Fix browser links #138
Merged
Fix browser links #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
isakstenstrom
commented
Sep 11, 2025
isakstenstrom
commented
- Bb-portal now links to its own browser functionality instead of linking to bb-browser.
- Links to to things that require a instance name in the URL are now working.
- The instance name of an invocation is shown on the invocation overview.
trey-ivy
approved these changes
Sep 12, 2025
There was a problem hiding this comment.
sorry your comment in the PR description is a little confusing. It seems like all this is doing is really adding the instanceName to the URL that gets generated, which is good because I have a workaround for this on my ingress....but the description says
Bb-portal now links to its own browser functionality instead of linking to bb-browser.
Can you explain what this means?
|
Yeah that's not too descriptive. Instead configuring the address to bb-browser with an environment variable, we just link to the built in browser instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.