Merge API versions in MergingProvider #276
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb_clientd was hardcoded to report API version 2.3 regardless of upstream provider capabilities, causing Bazel 8+ compatibility issues when proxying to servers limited to older API versions (like 2.0). This change implements proper API version intersection logic in MergingProvider to negotiate the highest mutually supported version between upstream providers. Particularly relevant for Bazel 8+, which uses output_files vs output_paths based on reported server version.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bb_clientd was hardcoded to report API version 2.3 regardless of upstream provider capabilities, causing Bazel 8+ compatibility issues when proxying to servers limited to older API versions (like 2.0).
This change implements proper API version intersection logic in MergingProvider to negotiate the highest mutually supported version between upstream providers.
Particularly relevant for Bazel 8+, which uses output_files vs output_paths based on reported server version.