fixed sound units #411
Merged
fixed sound units #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes 168, although the issue is not very clear the units needed fixing
|
fixes #168, but for some reason the issue does not appear in the Development automation. So I leave it referenced here. |
atomczak
reviewed
May 19, 2025
Documentation/UserManual/units.md
Outdated
| | IFCSOUNDPOWERMEASURE | Sound power | decibel | db | db | (0, 0, 0, 0, 0, 0, 0) | IfcDerivedUnitEnum.SOUNDPOWERUNIT | | | ||
| | IFCSOUNDPRESSURELEVELMEASURE | Sound pressure level | decibel | db | db | (0, 0, 0, 0, 0, 0, 0) | IfcDerivedUnitEnum.SOUNDPRESSURELEVELUNIT | | | ||
| | IFCSOUNDPRESSUREMEASURE | Sound pressure | decibel | db | db | (0, 0, 0, 0, 0, 0, 0) | IfcDerivedUnitEnum.SOUNDPRESSUREUNIT | | | ||
| | IFCSOUNDPOWERLEVELMEASURE | Sound power level (log ref. 1e-12 W) | decibel SWL | db(SWL) | db | (0, 0, 0, 0, 0, 0, 0) | IfcDerivedUnitEnum.SOUNDPOWERLEVELUNIT | | |
There was a problem hiding this comment.
Can't we just use 'decibel' unit, without the SPL/SWL? Whether it's the perceived noise (SPL) or source specs (SWL) it's defined in a property.
There was a problem hiding this comment.
I was attempting to ensure that the identification was unique.
But it can be resolved by the measure in context.
simplified db units.
atomczak
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes 168, although the issue is not very clear the units needed fixing