Configure dimensions merges in the workspace

Author: claytongentry

lib/manifold/api/workspace.rb

@@ -111,6 +111,7 @@ def generate_terraform
           vector_config = @vector_service.load_vector_config(vector)
           config.add_vector(vector_config)
         end
+        config.set_merge_config(manifold_yaml["dimensions"]&.fetch("merge", nil)) if manifold_yaml["dimensions"]
         config.write(terraform_main_path)
       end
     end

lib/manifold/templates/vector_template.yml

@@ -9,7 +9,3 @@ attributes:
   # key_values:
   #   first_key: STRING
   #   second_key: STRING:REQUIRED
-
-# Optionally, reference a view specifying how to select vector dimensions
-# merge:
-#   source: lib/views/select_my_vector.sql

lib/manifold/templates/workspace_template.yml

@@ -3,6 +3,11 @@ vectors:
   # Example:
   # - User
 
+dimensions:
+  # Reference a view specifying how to select vector dimensions
+  merge:
+    source: lib/views/select_my_vector.sql
+
 metrics:
   - name: # Add your metric name here, e.g. Pageviews
 

lib/manifold/terraform/workspace_configuration.rb

@@ -10,12 +10,17 @@ def initialize(name)
         super()
         @name = name
         @vectors = []
+        @merge_config = nil
       end
 
       def add_vector(vector_config)
         @vectors << vector_config
       end
 
+      def set_merge_config(merge_config)
+        @merge_config = merge_config
+      end
+
       def as_json
         {
           "variable" => variables_block,
@@ -61,15 +66,13 @@ def table_config
       end
 
       def routine_config
-        return nil if @vectors.empty?
+        return nil if @vectors.empty? || @merge_config.nil?
 
-        routines = @vectors.filter_map { |vector| build_routine(vector) }
-        routines.empty? ? nil : routines.to_h
+        routines = @vectors.map { |vector| build_routine(vector) }
+        routines.to_h
       end
 
       def build_routine(vector)
-        return nil unless vector["merge"]&.fetch("source", nil)
-
         routine_name = "merge_#{vector["name"].downcase}_dimensions"
         [routine_name, routine_attributes(routine_name, vector)]
       end
@@ -87,7 +90,7 @@ def routine_attributes(routine_name, vector)
       end
 
       def merge_routine_definition(vector)
-        source_sql = read_source_sql(vector["merge"]["source"])
+        source_sql = read_source_sql(@merge_config["source"])
         <<~SQL
           MERGE #{name}.Dimensions AS TARGET
           USING (

spec/manifold/api/workspace_spec.rb

@@ -179,6 +179,9 @@ def setup_workspace_files
         workspace.manifold_path.write(<<~YAML)
           vectors:
             - Page
+          dimensions:
+            merge:
+              source: lib/routines/select_pages.sql
         YAML
       end
 

spec/manifold/terraform/workspace_configuration_spec.rb

@@ -35,6 +35,7 @@
       before do
         setup_merge_vector_config
         config.add_vector(vector_config)
+        config.set_merge_config({ "source" => "lib/routines/select_pages.sql" })
       end
 
       it "includes routine configuration" do