fix(rumqttc): remove request_tx from EventLoop to allow gracefully exit
#977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracefully terminate
bitcapybara
changed the title
request_tx from EventLoop to allow EventLoop to gracefully exitrequest_tx from EventLoop to allow gracefully exit
|
We have also struggled with gracefully shutting down rumqttc, and I would really like to see this issue solved as the solution we've been forced to employ is quite convoluted. For a truly graceful shutdown, the event loop should send a disconnect packet rather than just dropping the connection, which I believe is what this current solution does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #975
Breaking change
By removing the unused
request_txfield fromEventLoop,EventLoopcan achieve graceful shutdown by triggering aRequestsDoneerror when allAsyncClient(Sender) instances have exited.This code change alters the return value of the EventLoop::new method, breaking backward compatibility with the existing API.