Skip to content

Turn warnings into errors in CI #4397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Turn warnings into errors in CI #4397

wants to merge 1 commit into from

Conversation

lum1n0us
Copy link
Collaborator

  • Apply global warnings in config_common.cmake instead of maintaining them in separate files.
  • Enable errors during CI when building iwasm and wamrc

@lum1n0us lum1n0us linked an issue Jun 20, 2025 that may be closed by this pull request
Enables errors for implicit function declaration by default #4317
Open
@lum1n0us lum1n0us force-pushed the fix/global_wanring_options branch 8 times, most recently from f5a4210 to b1a3ca5 Compare June 27, 2025 05:15
@lum1n0us lum1n0us force-pushed the fix/global_wanring_options branch from f553bd8 to c3cb9e0 Compare July 1, 2025 02:41
@lum1n0us lum1n0us mentioned this pull request Jul 1, 2025
Open
@lum1n0us lum1n0us marked this pull request as ready for review July 1, 2025 06:08
loganek
loganek reviewed Jul 1, 2025
View reviewed changes
yamt
yamt reviewed Jul 3, 2025
View reviewed changes
@lum1n0us lum1n0us force-pushed the fix/global_wanring_options branch from c3cb9e0 to 3eaf5a9 Compare July 3, 2025 06:24
@lum1n0us lum1n0us mentioned this pull request Jul 9, 2025
Merged
@lum1n0us lum1n0us force-pushed the fix/global_wanring_options branch from 3eaf5a9 to 02eaa53 Compare July 11, 2025 03:43
@lum1n0us
Turn warnings into errors in CI
0050677 
- Apply global warnings in warnings.cmake instead of maintaining them in
  separate files.
- Enable errors during CI when building iwasm and wamrc.
- Since GCC and Clang are the default compilers on Ubuntu and macOS, enabling
  `-Werror` on both platforms can be treated as checking with different
  compilers.
@lum1n0us lum1n0us force-pushed the fix/global_wanring_options branch from 02eaa53 to 0050677 Compare July 11, 2025 05:11
@lum1n0us lum1n0us added the enhancement Check if this issue/PR enhances a feature; scripts will use this info. label Jul 14, 2025
@lum1n0us lum1n0us added breaking-change Determine if this PR introduces breaking changes. It will be used by scripts to classify PRs. and removed enhancement Check if this issue/PR enhances a feature; scripts will use this info. labels Aug 1, 2025
@lum1n0us
Copy link
Collaborator Author

lum1n0us commented Aug 1, 2025

@yamt @loganek we are planning to merge this pull request, which will impact the current continuous integration or release process. Please provide your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamt yamt yamt left review comments

@loganek loganek loganek left review comments

@TianlongLiang TianlongLiang TianlongLiang approved these changes

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
breaking-change Determine if this PR introduces breaking changes. It will be used by scripts to classify PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enables errors for implicit function declaration by default
4 participants
@lum1n0us @yamt @loganek @TianlongLiang