feat(repo): Code optimization, display support and automated script for installation #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Also add support for the Waveshare 1.54 inch V2 Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
…t blocks for traceability Also change a little the position for the 1.54inch display Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
…on path Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
…nfig.toml if not exists Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Also if you restart the daemon the changes will be applied Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Now the position can be configured via the config.toml file Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
The configuration now needs to be configured with a string separated with commas Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
This error force the user to declare position_x and position_y when that variables are not used Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
I really mess up the differences trying to make an amend :( Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
After a lot of testing, I think this is the best way to add the position to the config.toml file Signed-off-by: nothingbutlucas <69118979+nothingbutlucas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, how are you?
Thanks for creating this plugin, It is extremely useful!
In general terms the changes I made were:
Add bash script for an automatic installation of the plugin (Giving also as an advantage, the possibility to do a
git pulland update the plugin).Add support for Waveshare 1.54 Inch V2 screen.
Add support for other types of potfiles
Add try, excepts and logs
Optimize code
I hope you like the changes I made, greetings!