-
Notifications
You must be signed in to change notification settings - Fork 3
Consolidate duplicate configuration #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Configuration applied both to Debug and Release, so I merge this settings. Obviously unrelated to bug, but cannot resist and not cleanup
Hello, no problem, would you like to work together? |
I already figure out the issue with drag drop. FYI: Also on RC1 you have to implement bunch of methods and properties and Pi property can be a problem for example |
Please, whats the problem with Pi? And witch (group of) functions are missing? public static BigRational Pi(int digits) |
This interface https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Numerics/IFloatingPoint.cs now derives from this one as you will see, it has Pi property. You cannot have property |
Thanks, I see, so far I don't support IFoatingPoint. It wouldn't be no problem to implement something, but does it make sense for such a number type? There is no constant for this, not even a cache (but it is planned). Within calculations, even low-level, cpu.sin, cpu.tan, when pi is requested, it is calculated in real-time in the currently desired precision. But these are the design questions I really need help with. |
You cannot not implement it, or you have to implement, but make it |
I use this as reference: There in INumber and INumberBase IFloatingPointConstants is not included. |
I'm not sure from which version of .NET source.dot.net gets source code, but I give you source code for latest bits from main branch. That's where dev works. And that's for sure would be either in Preview 7, or in RC1. If you install RC1 from here https://github.com/dotnet/installer you will see the issue yourself. Just be prepared before release to update things. |
Please take a look at approximate changes which would be required #7 |
Many thanks for the hints - I need time to check. |
I have it, they put IFloatingPointConstants in IRootFunctions, ITrigonometricFunctions. Thanks for hardware... |
My idea was rename |
This works too: static BigRational IFloatingPointConstants<BigRational>.Pi => Pi(1000) // :-) |
Thanks again, that was all very helpful. Latest NET7 version checked in, no more conflicts. From this morning, have you seen the last notes? Please not wondering if BigInteger sometimes crashes. |
Configuration applied both to Debug and Release, so I merge this settings.
Obviously unrelated to bug, but cannot resist and not cleanup