Conversation
Codecov Report
@@ Coverage Diff @@
## master #2232 +/- ##
=======================================
Coverage 73.88% 73.88%
=======================================
Files 51 51
Lines 4185 4185
=======================================
Hits 3092 3092
Misses 1093 1093Continue to review full report at Codecov.
|
panthony
left a comment
panthony
left a comment
There was a problem hiding this comment.
Thanks for your contribution.
Please address the requested changes so that we can proceed.
| typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() : | ||
| typeof define === 'function' && define.amd ? define(factory) : | ||
| (global.c3 = factory()); | ||
| typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() : |
There was a problem hiding this comment.
You modified the distribution file!
You should modify the proper file from src directory and not commit the c3.js file which is overwritten during release
There was a problem hiding this comment.
I think this is just the indentation issue with my editor. I don't see any chages here.
There was a problem hiding this comment.
What I meant is that you modified the c3.js file which is the distribution file and that this file should not be part of the pull request.
There was a problem hiding this comment.
@panthony i have make the requested changes. I have moved the logic to legend.js and config.js
You can review chnages.
c3.js
Outdated
| legend_padding: 0, | ||
| legend_item_tile_width: 10, | ||
| legend_item_tile_height: 10, | ||
| legend_format: undefined, |
There was a problem hiding this comment.
Please, also add the documentation for this new option. The documentation site has been added to the repository.
c3.js
Outdated
| if(config.legend_format && isFunction(config.legend_format)) { | ||
| return config.legend_format(id, index); | ||
| } else { | ||
| return isDefined(config.data_names[id]) ? config.data_names[id] : id; |
There was a problem hiding this comment.
Please, do not repeat the logic that resolve the legend's name.
There was a problem hiding this comment.
@pkpatels I saw the same logic twice but it must have been between c3.js and legend.js files.
Your pull request still includes the c3.js file although it should not be committed.
panthony
added
waiting on submitter
R-needs-tests
|
@panthony I have made the requested changes. |
3 participants
No description provided.