Open
Conversation
This was referenced Nov 6, 2025
francislavoie
requested changes
Feb 18, 2026
| @@ -0,0 +1,8 @@ | |||
| //go:build !linux || nosystemd | |||
Member
There was a problem hiding this comment.
Drop this file and remove the nosystemd build tag & filename, we don't need to exclude global placeholders. Either the user has systemd and uses the placeholders, or they don't have systemd and don't use the placeholders. It's fine. Keep it simple.
Contributor
Author
There was a problem hiding this comment.
with the convention in master we would have replacer_other.go here with the same contents. nosystemd is more precise than other is for !linux. we can rename notify_other.go to notify_nosystemd.go to make them match after.
| @@ -0,0 +1,376 @@ | |||
| //go:build linux && !nosystemd | |||
Member
There was a problem hiding this comment.
Rename the file to replacer_test_linux.go
Suggested change
| //go:build linux && !nosystemd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assistance Disclosure
No AI was used.
Implements #7331 as a placeholder,
bind sd/name/3->bind fd/{systemd.listen.name:3}. A custom network was only beneficial to implement support with a plugin, the actual behavior needed was just a fancy{env.*}that substitutes the index of a value from an array in the environment. Using one avoids complicating the config syntax and parsing, and sets us up for more systemd placeholders like{systemd.creds.*}.