Skip to content

Commit 2956079

Browse files
committed
fix start worklfow test
1 parent 66c821a commit 2956079

File tree

1 file changed

+21
-7
lines changed

1 file changed

+21
-7
lines changed

src/test/java/com/uber/cadence/internal/tracing/StartWorkflowTest.java

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import com.uber.cadence.serviceclient.ClientOptions;
3131
import com.uber.cadence.serviceclient.IWorkflowService;
3232
import com.uber.cadence.serviceclient.WorkflowServiceTChannel;
33+
import com.uber.cadence.testUtils.TestEnvironment;
3334
import com.uber.cadence.worker.Worker;
3435
import com.uber.cadence.worker.WorkerFactory;
3536
import com.uber.cadence.worker.WorkerFactoryOptions;
@@ -138,8 +139,7 @@ public Integer Double(Integer n) {
138139
}
139140
}
140141

141-
private static final boolean useDockerService =
142-
Boolean.parseBoolean(System.getenv("USE_DOCKER_SERVICE"));
142+
private static final boolean useDockerService = true || TestEnvironment.isUseDockerService();
143143
private static final Logger logger = LoggerFactory.getLogger(StartWorkflowTest.class);
144144
private static final String DOMAIN = "test-domain";
145145
private static final String TASK_LIST = "test-tasklist";
@@ -160,7 +160,11 @@ public void testStartWorkflowGRPC() {
160160
IWorkflowService service =
161161
new Thrift2ProtoAdapter(
162162
IGrpcServiceStubs.newInstance(
163-
ClientOptions.newBuilder().setTracer(mockTracer).setPort(7833).build()));
163+
ClientOptions.newBuilder()
164+
.setTracer(mockTracer)
165+
.setHost("localhost")
166+
.setPort(7833)
167+
.build()));
164168
testStartWorkflowHelper(service, mockTracer, true);
165169
}
166170

@@ -171,7 +175,11 @@ public void testStartMultipleWorkflowGRPC() {
171175
IWorkflowService service =
172176
new Thrift2ProtoAdapter(
173177
IGrpcServiceStubs.newInstance(
174-
ClientOptions.newBuilder().setTracer(mockTracer).setPort(7833).build()));
178+
ClientOptions.newBuilder()
179+
.setTracer(mockTracer)
180+
.setHost("localhost")
181+
.setPort(7833)
182+
.build()));
175183
try {
176184
service.RegisterDomain(new RegisterDomainRequest().setName(DOMAIN));
177185
} catch (DomainAlreadyExistsError e) {
@@ -259,7 +267,11 @@ public void testSignalWithStartWorkflowGRPC() {
259267
IWorkflowService service =
260268
new Thrift2ProtoAdapter(
261269
IGrpcServiceStubs.newInstance(
262-
ClientOptions.newBuilder().setTracer(mockTracer).setPort(7833).build()));
270+
ClientOptions.newBuilder()
271+
.setTracer(mockTracer)
272+
.setHost("localhost")
273+
.setPort(7833)
274+
.build()));
263275
testSignalWithStartWorkflowHelper(service, mockTracer, true);
264276
}
265277

@@ -277,7 +289,8 @@ public void testStartWorkflowGRPCNoPropagation() {
277289
MockTracer mockTracer = new MockTracer();
278290
IWorkflowService service =
279291
new Thrift2ProtoAdapter(
280-
IGrpcServiceStubs.newInstance(ClientOptions.newBuilder().setPort(7833).build()));
292+
IGrpcServiceStubs.newInstance(
293+
ClientOptions.newBuilder().setHost("localhost").setPort(7833).build()));
281294
testStartWorkflowHelper(service, mockTracer, false);
282295
}
283296

@@ -295,7 +308,8 @@ public void testSignalStartWorkflowGRPCNoPropagation() {
295308
MockTracer mockTracer = new MockTracer();
296309
IWorkflowService service =
297310
new Thrift2ProtoAdapter(
298-
IGrpcServiceStubs.newInstance(ClientOptions.newBuilder().setPort(7833).build()));
311+
IGrpcServiceStubs.newInstance(
312+
ClientOptions.newBuilder().setHost("localhost").setPort(7833).build()));
299313
testSignalWithStartWorkflowHelper(service, mockTracer, false);
300314
}
301315

0 commit comments

Comments
 (0)