Skip to content

Commit c89a6b9

Browse files
committed
another few set of tests
1 parent 2956079 commit c89a6b9

File tree

3 files changed

+9
-15
lines changed

3 files changed

+9
-15
lines changed

src/test/java/com/uber/cadence/worker/CleanWorkerShutdownTest.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,8 @@
3232
import com.uber.cadence.client.WorkflowClient;
3333
import com.uber.cadence.client.WorkflowClientOptions;
3434
import com.uber.cadence.client.WorkflowOptions;
35-
import com.uber.cadence.serviceclient.ClientOptions;
3635
import com.uber.cadence.serviceclient.IWorkflowService;
37-
import com.uber.cadence.serviceclient.WorkflowServiceTChannel;
36+
import com.uber.cadence.testUtils.TestEnvironment;
3837
import com.uber.cadence.testing.TestEnvironmentOptions;
3938
import com.uber.cadence.testing.TestWorkflowEnvironment;
4039
import com.uber.cadence.workflow.Workflow;
@@ -57,8 +56,7 @@
5756
@RunWith(Parameterized.class)
5857
public class CleanWorkerShutdownTest {
5958

60-
private static final boolean useDockerService =
61-
Boolean.parseBoolean(System.getenv("USE_DOCKER_SERVICE"));
59+
private static final boolean useDockerService = TestEnvironment.isUseDockerService();
6260

6361
@Parameterized.Parameter public boolean useExternalService;
6462

@@ -81,7 +79,7 @@ public static Object[] data() {
8179
@Before
8280
public void setUp() {
8381
if (useExternalService) {
84-
service = new WorkflowServiceTChannel(ClientOptions.defaultInstance());
82+
service = TestEnvironment.getDockerService();
8583
}
8684
}
8785

src/test/java/com/uber/cadence/worker/WorkerStressTests.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,8 @@
2626
import com.uber.cadence.client.WorkflowClientOptions;
2727
import com.uber.cadence.client.WorkflowOptions;
2828
import com.uber.cadence.client.WorkflowStub;
29-
import com.uber.cadence.serviceclient.ClientOptions;
3029
import com.uber.cadence.serviceclient.IWorkflowService;
31-
import com.uber.cadence.serviceclient.WorkflowServiceTChannel;
30+
import com.uber.cadence.testUtils.TestEnvironment;
3231
import com.uber.cadence.testing.TestEnvironmentOptions;
3332
import com.uber.cadence.testing.TestWorkflowEnvironment;
3433
import com.uber.cadence.workflow.Async;
@@ -53,8 +52,7 @@
5352
@RunWith(Parameterized.class)
5453
public class WorkerStressTests {
5554

56-
private static final boolean useDockerService =
57-
Boolean.parseBoolean(System.getenv("USE_DOCKER_SERVICE"));
55+
private static final boolean useDockerService = true || TestEnvironment.isUseDockerService();
5856

5957
@Parameterized.Parameter public boolean useExternalService;
6058

@@ -181,7 +179,7 @@ public TestEnvironmentWrapper(WorkerFactoryOptions options) {
181179
WorkflowClientOptions clientOptions =
182180
WorkflowClientOptions.newBuilder().setDomain(DOMAIN).build();
183181
if (useDockerService) {
184-
IWorkflowService service = new WorkflowServiceTChannel(ClientOptions.defaultInstance());
182+
IWorkflowService service = TestEnvironment.getDockerService();
185183
WorkflowClient client = WorkflowClient.newInstance(service, clientOptions);
186184
factory = WorkerFactory.newInstance(client, options);
187185
} else {

src/test/java/com/uber/cadence/workerFactory/WorkerFactoryTests.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,8 @@
2020
import static org.junit.Assert.*;
2121

2222
import com.uber.cadence.client.WorkflowClient;
23-
import com.uber.cadence.serviceclient.ClientOptions;
2423
import com.uber.cadence.serviceclient.IWorkflowService;
25-
import com.uber.cadence.serviceclient.WorkflowServiceTChannel;
24+
import com.uber.cadence.testUtils.TestEnvironment;
2625
import com.uber.cadence.worker.WorkerFactory;
2726
import java.util.concurrent.TimeUnit;
2827
import org.junit.After;
@@ -33,8 +32,7 @@
3332

3433
public class WorkerFactoryTests {
3534

36-
private static final boolean useDockerService =
37-
Boolean.parseBoolean(System.getenv("USE_DOCKER_SERVICE"));
35+
private static final boolean useDockerService = TestEnvironment.isUseDockerService();
3836

3937
@BeforeClass
4038
public static void beforeClass() {
@@ -47,7 +45,7 @@ public static void beforeClass() {
4745

4846
@Before
4947
public void setUp() {
50-
service = new WorkflowServiceTChannel(ClientOptions.defaultInstance());
48+
service = TestEnvironment.getDockerService();
5149
client = WorkflowClient.newInstance(service);
5250
factory = WorkerFactory.newInstance(client);
5351
}

0 commit comments

Comments
 (0)