JOSS review - bdice

[bdice]

Hi! Thank you for your patience on my JOSS review for CADET-core (openjournals/joss-reviews#7881).

I have reviewed the software and found everything in tip-top shape: docs, licenses, contributing guides, installation instructions, and the JupyterHub server you shared with me containing a tutorial all worked as expected. I was able to reproduce the results of https://github.com/cadet/CADET-Workshop on my local machine as well (running Ubuntu).

At first I had some confusion around the same issues listed in #373 - but I think some of the revisions that have already been made have helped in this area. The discussion from @lieres here (openjournals/joss-reviews#7881 (comment)) was very helpful for me as a reviewer.

My only significant request for improvements would be here:

State of the field: Do the authors describe how this software compares to other commonly-used packages?

I have enough knowledge of chromatography to understand the scope and purpose of CADET, but I don't know much about other software in this field. It seems like other software I could find in this area is commercial / non-OSS, but it may be worth mentioning to give the reader a better understanding of the current landscape.

Let's discuss on this issue - feel free to make some changes in the paper, or explain if you think no changes are warranted, and then I can approve the JOSS review.

[hannahlanzrath]

Hello Bradley Dice,

Thank you very much for your review and the positive feedback. We really appreciate the time and effort you put into evaluating CADET-Core!

Regarding your comment on the State of the field, we've expanded on this point in a dedicated section of the paper. The changes are included in the following commit: 8427323.

You can also find the updated PDF here: 10.21105.joss.07881.pdf

In this revision, we briefly describe the current landscape of chromatography simulation software, emphasizing that most alternatives are commercial and closed-source, as you already noted. We hope this provides useful context for readers.

Please let us know if this addition addresses your concerns.

Thanks again!

[bdice]

Awesome! Thank you. Because I am a little less familiar with this field, the "State of the Field" section is really valuable to contextualize CADET in the broader space of chromatography. I will close this issue as complete and follow up on openjournals/joss-reviews#7881.