Request for obtaining a PHP extension php-ext-mmap compatible with PHP 8 as an SO file.

[wf58585858]

Hello,

I've been studying how to operate Raspberry Pi using PHP recently. The model I'm working with is 3b, and the operating system is almalinux 9. I've looked into many libraries and found that most of them operate on /sys/class/gpio. After comparing, I believe your library has the most comprehensive functionality and better performance. However, I've encountered some issues while using it. These issues involve low-level operations of the operating system, and my understanding of the system is insufficient to resolve them. Therefore, I'm seeking your help.

I've noticed that your library hasn't been updated for quite some time. There are some deprecated syntax warnings when using PHP 8.1, but I've made modifications to address these issues, and they have been resolved.

The current issue lies with mmap. When using the Python script method, I encounter the following errors:

Traceback (most recent call last):
  File "/var/www/6002/calcinai/vendor/calcinai/php-mmap/lib/MMap/../../subprocess/mmap-proxy.py", line 19, in <module>
    address = struct.unpack('<H', sys.stdin.read(2))[0];
TypeError: a bytes-like object is required, not 'str'

I attempted to compile your https://github.com/calcinai/php-ext-mmap, but it also resulted in an error:

┌─[root@alma9-v4-2-12-4] - [/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap] - [2024-03-30 12:00:00]
└─[0] <> make install
/bin/sh /var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/libtool --mode=compile cc -I. -I/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap -I/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/include -I/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/main -I/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap -I/usr/include/php -I/usr/include/php/main -I/usr/include/php/TSRM -I/usr/include/php/Zend -I/usr/include/php/ext -I/usr/include/php/ext/date/lib  -DHAVE_CONFIG_H  -g -O2    -c /var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/mmap.c -o mmap.lo 
libtool: compile:  cc -I. -I/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap -I/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/include -I/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/main -I/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap -I/usr/include/php -I/usr/include/php/main -I/usr/include/php/TSRM -I/usr/include/php/Zend -I/usr/include/php/ext -I/usr/include/php/ext/date/lib -DHAVE_CONFIG_H -g -O2 -c /var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/mmap.c  -fPIC -DPIC -o .libs/mmap.o
In file included from /var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/mmap.c:5:
/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/php_mmap.h:11:80: error: expected ‘;’, ‘,’ or ‘)’ before ‘TSRMLS_DC’
   11 | size_t mmap_stream_write(php_stream *stream, const char *buffer, size_t length TSRMLS_DC); size_t mmap_stream_read(php_stream *stream, char *buffer, size_t length TSRMLS_DC); int mmap_stream_flush(php_stream *stream TSRMLS_DC); int mmap_stream_seek(php_stream *stream, zend_off_t offset, int whence, zend_off_t *newoffset);
      |                                                                                ^~~~~~~~~
/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/php_mmap.h:12:73: error: expected ‘;’, ‘,’ or ‘)’ before ‘TSRMLS_DC’
   12 | int mmap_stream_close(php_stream *stream, int close_handle TSRMLS_DC);
      |                                                                         ^        
/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/php_mmap.h:13:42: error: expected ‘;’, ‘,’ or ‘)’ before ‘TSRMLS_DC’
   13 | 
      |                                          ^        
/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/php_mmap.h:15:72: error: expected ‘;’, ‘,’ or ‘)’ before ‘TSRMLS_DC’
   15 |         void *base_offset;      void *current_offset;   int length; };
      |                                                                        ^        
/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/mmap.c:39:5: error: ‘mmap_stream_write’ undeclared here (not in a function); did you mean ‘_php_stream_write’?
   39 |     mmap_stream_write,
      |     ^~~~~~~~~~~~~~~~~
      |     _php_stream_write
/var/www/6025/componentsTest/gpio/mmap/php-ext-mmap/mmap.c:40:5: error: ‘mmap_stream_read’ undeclared here (not in a function); did you mean ‘mmap_stream_seek’?
   40 |     mmap_stream_read,
      |     ^~~~~~~~~~~~~~~~
      |     mmap_stream_seek

So I'm not sure if you have the energy and time, but if possible, could you compile php-ext-mmap into an SO file and include it in the release, compatible with PHP 8.1 to 8.2?

appreciate it！

[calcinai]

Hi @wf58585858 Apologies for the slow response. I'll take a look at this over the weekend and see if I can fix both issues!

[wf58585858]

Thank you for the response!

Based on my research, I found that the official OS from Raspberry Pi is more compatible with Raspberry Pi, so I switched to using the official OS.

Additionally, I have a few optimization suggestions. Please see if you can consider adopting them, if it's not too much trouble.

1. PHP has now reached version 8.3. It may be worth compiling various releases of https://github.com/calcinai/php-ext-mmap to make it easier for those in need to use. So far, I haven't found a library that can replace this functionality, so your library might be helpful to many people.

2. Open a project on packagist.org to provide fread(), fwrite(), fseek(), fclose() for mmap, with OS files directly placed in the PHP source code and imported using the dl function. This approach is only effective in CLI. If users are using php-fpm, give them a prompt to configure it in php.ini. Basically, if there are no bug-related issues, maintenance may not be necessary in the future.

3. Update https://github.com/calcinai/phpi to adapt to PHP 8 syntax and Raspberry Pi 5. Syntax before PHP 7.4 can be disregarded for compatibility. Import mmap via Composer so that Python-related issues are not a concern. After all, if someone knows Python, they might not need this project.

┌─[root@raspberrypi] - [/sys/class/gpio] - [2024-04-10 03:53:00]
└─[0] <> lla                 
total 0
drwxrwxr-x  2 root gpio    0 2024/04/04 11:19:42 ./
drwxr-xr-x 65 root root    0 1970/01/01 01:00:03 ../
--w--w----  1 root gpio 4.0K 2024/04/04 11:19:42 export
lrwxrwxrwx  1 root gpio    0 2024/04/04 11:19:42 gpiochip512 -> ../../devices/platform/soc/3f200000.gpio/gpio/gpiochip512/
lrwxrwxrwx  1 root gpio    0 2024/04/04 11:19:42 gpiochip566 -> ../../devices/platform/soc/soc:firmware/soc:firmware:expgpio/gpio/gpiochip566/
--w--w----  1 root gpio 4.0K 2024/04/04 11:19:42 unexport

You can see that the base number is 512. Many tutorials suggest using echo 10 > /sys/class/gpio/export to export a pin.
In my case this doesn't work; I have to use echo 522 > /sys/class/gpio/export to export the same pin. So when I operate GPIO, it looks like this:

┌─[root@raspberrypi] - [/sys/class/gpio] - [2024-04-10 03:53:01]
└─[0] <> echo 10 > export       
echo: write error: invalid argument

┌─[root@raspberrypi] - [/sys/class/gpio] - [2024-04-10 03:55:15]
└─[1] <> echo 522 > /sys/class/gpio/export

┌─[root@raspberrypi] - [/sys/class/gpio] - [2024-04-10 03:57:16]
└─[0] <> lla
total 0
drwxrwxr-x  2 root gpio    0 2024/04/10 03:57:16 ./
drwxr-xr-x 65 root root    0 1970/01/01 01:00:03 ../
--w--w----  1 root gpio 4.0K 2024/04/10 03:57:16 export
lrwxrwxrwx  1 root root    0 2024/04/10 03:57:19 gpio522 -> ../../devices/platform/soc/3f200000.gpio/gpiochip0/gpio/gpio522/
lrwxrwxrwx  1 root gpio    0 2024/04/04 11:19:42 gpiochip512 -> ../../devices/platform/soc/3f200000.gpio/gpio/gpiochip512/
lrwxrwxrwx  1 root gpio    0 2024/04/04 11:19:42 gpiochip566 -> ../../devices/platform/soc/soc:firmware/soc:firmware:expgpio/gpio/gpiochip566/
--w--w----  1 root gpio 4.0K 2024/04/04 11:19:42 unexport

┌─[root@raspberrypi] - [/sys/class/gpio] - [2024-04-10 03:57:19]
└─[0] <> echo 1 > gpio522/value    

┌─[root@raspberrypi] - [/sys/class/gpio] - [2024-04-10 03:58:15]
└─[0] <> cat gpio522/value
1

┌─[root@raspberrypi] - [/sys/class/gpio] - [2024-04-10 03:58:28]
└─[0] <> 

I've noticed that some Raspberry Pis have this problem while others don't. So I'm not sure if your library can automatically handle this issue.
Do you need to add a setting like setBaseNumber(512) during initialization?

5. In demo/info.php , the renderHeader function can be replaced with the Table class from symfony/console, which is more elegant!

https://symfony.com/doc/current/components/console/helpers/table.html

like this :

   	use Symfony\Component\Console\Helper\Table;
   	
       $table = new Table($output);
       $table
           ->setHeaders(['ISBN', 'Title', 'Author'])
           ->setRows([
               ['99921-58-10-7', 'Divine Comedy', 'Dante Alighieri'],
               ['9971-5-0210-0', 'A Tale of Two Cities', 'Charles Dickens'],
               ['960-425-059-0', 'The Lord of the Rings', 'J. R. R. Tolkien'],
               ['80-902734-1-6', 'And Then There Were None', 'Agatha Christie'],
           ])
       ;
       $table->render();
   	

[wf58585858]

buddy？

[calcinai]

@wf58585858 I'm sorry I haven't had a change to get to this. Are you able to open a pul request with the proposed changes?

[wf58585858]

I'm sorry, this might be too much work and could trouble you.
To make it simpler, could you modify the https://github.com/calcinai/php-ext-mmap repository to compile a .so file compatible with PHP 8.3 and put it in the releases?
I really can't do this;
I can handle PHP code issues myself.
Thank you very much!