fix: minimize usage of process.exit(1)

Author: satya164

packages/create-react-native-library/src/index.ts

@@ -210,13 +210,11 @@ async function promptPath(argv: Args, local: boolean) {
   }
 
   if (await fs.pathExists(folder)) {
-    console.log(
+    throw new Error(
       `A folder already exists at ${kleur.blue(
         folder
       )}! Please specify another folder name or delete the existing one.`
     );
-
-    process.exit(1);
   }
 
   return folder;

packages/create-react-native-library/src/utils/assert.ts

@@ -9,13 +9,11 @@ export async function assertNpxExists() {
   } catch (error) {
     // @ts-expect-error: TS doesn't know about `code`
     if (error != null && error.code === 'ENOENT') {
-      console.log(
+      throw new Error(
         `Couldn't find ${kleur.blue(
           'npx'
         )}! Please install it by running ${kleur.blue('npm install -g npx')}`
       );
-
-      process.exit(1);
     } else {
       throw error;
     }
@@ -76,9 +74,7 @@ export function assertUserInput(
         message += `: ${validation}`;
       }
 
-      console.log(message);
-
-      process.exit(1);
+      throw new Error(message);
     }
   }
 }

packages/react-native-builder-bob/src/build.ts

@@ -34,46 +34,42 @@ export async function build(argv: Argv) {
   const result = loadConfig(root);
 
   if (!result?.config) {
-    logger.error(
+    throw new Error(
       `No configuration found. Run '${argv.$0} init' to create one automatically.`
     );
-    process.exit(1);
   }
 
   const options: Options = result!.config;
 
   if (!options.targets?.length) {
-    logger.error(
-      `No targets found in the configuration in '${path.relative(
+    throw new Error(
+      `No 'targets' found in the configuration in '${path.relative(
         root,
         result!.filepath
       )}'.`
     );
-    process.exit(1);
   }
 
   const source = options.source;
 
   if (!source) {
-    logger.error(
-      `No source option found in the configuration in '${path.relative(
+    throw new Error(
+      `No 'source' option found in the configuration in '${path.relative(
         root,
         result!.filepath
       )}'.`
     );
-    process.exit(1);
   }
 
   const output = options.output;
 
   if (!output) {
-    logger.error(
-      `No source option found in the configuration in '${path.relative(
+    throw new Error(
+      `No 'output' option found in the configuration in '${path.relative(
         root,
         result!.filepath
       )}'.`
     );
-    process.exit(1);
   }
 
   const exclude = options.exclude ?? '**/{__tests__,__fixtures__,__mocks__}/**';
@@ -197,7 +193,6 @@ async function buildTarget({
       });
       break;
     default:
-      logger.error(`Invalid target ${kleur.blue(targetName)}.`);
-      process.exit(1);
+      throw new Error(`Invalid target ${kleur.blue(targetName)}.`);
   }
 }

packages/react-native-builder-bob/src/init.ts

@@ -4,7 +4,6 @@ import kleur from 'kleur';
 import dedent from 'dedent';
 import isGitDirty from 'is-git-dirty';
 import prompts, { type PromptObject } from './utils/prompts';
-import * as logger from './utils/logger';
 import { loadConfig } from './utils/loadConfig';
 
 // eslint-disable-next-line @typescript-eslint/no-require-imports,import-x/no-commonjs
@@ -30,10 +29,9 @@ export async function init() {
   }
 
   if (!(await fs.pathExists(projectPackagePath))) {
-    logger.error(
+    throw new Error(
       `Couldn't find a 'package.json' file in '${root}'.\n  Are you in a project folder?`
     );
-    process.exit(1);
   }
 
   const pkg = JSON.parse(await fs.readFile(projectPackagePath, 'utf-8'));
@@ -71,10 +69,9 @@ export async function init() {
   }
 
   if (!entryFile) {
-    logger.error(
+    throw new Error(
       `Couldn't find a 'index.js'. 'index.ts' or 'index.tsx' file under '${source}'.\n  Please re-run the CLI after creating it.`
     );
-    process.exit(1);
   }
 
   pkg.devDependencies = Object.fromEntries(

packages/react-native-builder-bob/src/targets/codegen/index.ts

@@ -36,10 +36,9 @@ export default async function build({ root, report }: Options) {
   const codegenType = packageJson.codegenConfig?.type;
 
   if (codegenType === undefined) {
-    report.error(
+    throw new Error(
       "Couldn't find the 'type' value in 'codegenConfig'. Please check your package.json's 'codegenConfig' property and make sure 'type' is defined. https://reactnative.dev/docs/the-new-architecture/using-codegen#configuring-codegen"
     );
-    process.exit(1);
   }
 
   try {
@@ -54,7 +53,7 @@ export default async function build({ root, report }: Options) {
   } catch (e: unknown) {
     if (e != null && typeof e === 'object') {
       if ('stdout' in e && e.stdout != null) {
-        report.error(
+        throw new Error(
           `Errors found while generating codegen files:\n${e.stdout.toString()}`
         );
       } else if ('message' in e && typeof e.message === 'string') {
@@ -63,19 +62,13 @@ export default async function build({ root, report }: Options) {
             "Error: Cannot find module '@react-native-community/cli/package.json'"
           )
         ) {
-          report.error(
+          throw new Error(
             "You don't have `@react-native-community/cli` in your root package's dev dependencies. Please install it and make sure it uses the same version as your application."
           );
-        } else {
-          report.error(e.message);
         }
-      } else {
-        throw e;
       }
-    } else {
-      throw e;
     }
 
-    process.exit(1);
+    throw e;
   }
 }

packages/react-native-builder-bob/src/targets/custom.ts

@@ -3,7 +3,6 @@ import path from 'path';
 import fs from 'fs-extra';
 import type { Input } from '../types';
 import { spawn } from '../utils/spawn';
-import dedent from 'dedent';
 import del from 'del';
 
 type Options = Omit<Input, 'output'> & {
@@ -15,13 +14,11 @@ type Options = Omit<Input, 'output'> & {
 
 export default async function customTarget({ options, root, report }: Options) {
   if (options?.script == null) {
-    report.error(
-      dedent(
-        `No script was provided with the custom target.
-         Example: ${kleur.green('{["custom", { "script": "generateTypes" }}')}`
-      )
+    throw new Error(
+      `No 'script' was provided with the custom target. Example: ${kleur.green(
+        '{["custom", { "script": "generateTypes" }}'
+      )}`
     );
-    process.exit(1);
   }
 
   const pathToClean = options.clean
@@ -45,16 +42,9 @@ export default async function customTarget({ options, root, report }: Options) {
     )}`
   );
 
-  try {
-    await spawn(packageManagerExecutable, packageManagerArgs, {
-      stdio: ['ignore', 'ignore', 'inherit'],
-    });
-  } catch (e) {
-    report.error(
-      `An error occurred when running ${kleur.blue(options.script)}`
-    );
-    process.exit(1);
-  }
+  await spawn(packageManagerExecutable, packageManagerArgs, {
+    stdio: ['ignore', 'ignore', 'inherit'],
+  });
 
   report.success(`Ran the ${kleur.blue(options.script)} script succesfully`);