Apply typeface and size individually in android text appearance. #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a custom font with bottom tabs today on Android, another font size is also set by default. With the biggest difference from the standard one being that it scales with the system font scale, which the default one does not.
PR Description
Improvement: This splits the application of text appearance, so that size and typeface(family and weight) is applied individually. So that when setting one or the other, only that is applied. So one could use a custom font family, without getting the font scaling which is usually not wanted with tab bars.
How to test?
On Android apply
fontFamily
+fontWeight
andfontSize
individually intabLabelStyle
, and see they can be used individually.Screenshots
Before and after examples with bigger system font scale on Android