Feat(Group chat channels) #120
Conversation
There was a problem hiding this comment.
Thanks @Yuujee, very high quality code and very import feature to OASIS! Leave some comments on the details.
In addition, it might be better if you can add pytest test for these action, for example, add a test similar to https://github.com/camel-ai/oasis/blob/main/test/infra/database/test_user_create_post.py. And add the these new ActionType in the https://github.com/camel-ai/oasis/blob/main/test/agent/test_action_docstring.py and https://github.com/camel-ai/oasis/blob/main/test/agent/test_twitter_user_agent_all_actions.py.
For document, maybe it will be good to add these action's description in https://github.com/camel-ai/oasis/blob/main/docs/key_modules/actions.mdx. And if you are not familiar with mintlify deploy, I can also help with it later.
|
|
||
| async def main(): | ||
| # NOTE: You need to deploy the vllm server first | ||
| vllm_model_1 = ModelFactory.create( |
There was a problem hiding this comment.
Maybe deepseek_model_1 is more accurate.
| url="https://api.deepseek.com/v1", | ||
| api_key="ak", | ||
| ) | ||
| vllm_model_2 = ModelFactory.create( |
| env = oasis.make( | ||
| platform=oasis.DefaultPlatformType.TWITTER, | ||
| database_path=db_path, | ||
| agent_profile_path=( | ||
| "data/twitter_dataset/anonymous_topic_200_1h/False_Business_0.csv" | ||
| ), | ||
| agent_models=models, | ||
| available_actions=available_actions, | ||
| ) |
There was a problem hiding this comment.
The way to make the env and actions may need to be modified after the update, you can refer to https://github.com/camel-ai/oasis/blob/main/examples/twitter_simulation_openai.py
| """ | ||
| Creates a new group on the platform. | ||
|
|
||
| Args: | ||
| group_name (str): The name of the group to be created. | ||
|
|
||
| Returns: | ||
| dict: Platform response indicating success or failure, | ||
| e.g.{"success": True, "group_id": 1} | ||
| """ |
There was a problem hiding this comment.
For each docstring, it would be better to follow the Guideline for Writing Docstrings part in https://github.com/camel-ai/camel/blob/master/CONTRIBUTING.md
No description provided.