Update example for mocking call activities #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the example used `thenReturn` to mock call activities with a scenario. This worked well if the call activity is called only once. However, if the call activity would be called multiple times, the same scenario (as in "same Java object") would be reused. If users would copy this example into their own code, they could observe unexpected behaviour in their tests when calling activities multiple times. This commit changes the example to use `thenAnswer` to create a new scenario (with equal behaviour) for each call.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the example used
thenReturnto mock call activities with a scenario. This worked well if the call activity is called only once. However, if the call activity would be called multiple times, the same scenario (as in "same Java object") would be reused. If users would copy this example into their own code, they could observe unexpected behaviour in their tests when calling activities multiple times.This commit changes the example to use
thenAnswerto create a new scenario (with equal behaviour) for each call.