Skip to content
This repository was archived by the owner on Apr 8, 2024. It is now read-only.

Commit 8e81c16

Browse files
authored
0.20.0 release + timeout boolean (#59)
0.20.0 release + timeout boolean
2 parents ef3f532 + 5dcf359 commit 8e81c16

File tree

7 files changed

+11
-6
lines changed

7 files changed

+11
-6
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
test:
3434
docker:
3535
- image: circleci/node:11.10.1
36-
- image: sitapati/zeebe:0.20.0
36+
- image: camunda/zeebe:0.20.0
3737
working_directory: ~/zeebe-client-node-js
3838
steps:
3939
- checkout

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ Docker-compose configurations for Zeebe are available at [https://github.com/zee
1313

1414
To enable that the client libraries can be easily supported to the Zeebe server we are remapping the version numbers, so that Major, Minor match the server application. Patches will be independent and indicate client updates.
1515

16+
NPM Package version 0.20.x supports Zeebe 0.20.x
17+
1618
NPM Package version 0.19.x supports Zeebe 0.19.x
1719

1820
NPM Package version 2.x.x supports Zeebe 0.18.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "zeebe-node",
3-
"version": "v0.19.3",
3+
"version": "v0.20.0",
44
"description": "A Node.js client library for the Zeebe Microservices Orchestration Engine.",
55
"keywords": [
66
"zeebe",

src/__tests__/integration/ZBClient-integration.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,8 @@ describe('ZBClient', () => {
183183
attempts++
184184
// Succeed on the third attempt
185185
if (attempts === 3) {
186-
return complete()
186+
complete()
187+
return
187188
}
188189
complete.failure('Triggering a retry')
189190
if (attempts === 2) {

src/lib/GRPCClient.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export class GRPCClient {
3232

3333
for (const key in listMethods) {
3434
if (listMethods[key]) {
35-
const methodName = listMethods[key].originalName
35+
const methodName = listMethods[key].originalName as string
3636
this.listNameMethods.push(methodName)
3737

3838
this[`${methodName}Async`] = (data, fnAnswer) => {

src/lib/interfaces.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ export interface KeyedObject {
77
export type Loglevel = 'INFO' | 'DEBUG' | 'NONE' | 'ERROR'
88

99
export interface CompleteFn<WorkerOutputVariables> {
10-
(updatedVariables?: Partial<WorkerOutputVariables>): void
11-
success: (updatedVariables?: Partial<WorkerOutputVariables>) => void
10+
(updatedVariables?: Partial<WorkerOutputVariables>): boolean
11+
success: (updatedVariables?: Partial<WorkerOutputVariables>) => boolean
1212
failure: (errorMessage: string, retries?: number) => void
1313
}
1414

src/zb/ZBWorker.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,10 +261,12 @@ export class ZBWorker<
261261
this.logger.debug(
262262
`Completed task ${taskId} for ${this.taskType}`
263263
)
264+
return true
264265
} else {
265266
this.logger.debug(
266267
`Completed task ${taskId} for ${this.taskType}, however it had timed out.`
267268
)
269+
return false
268270
}
269271
}
270272
shadowWorkerCallback.success = shadowWorkerCallback

0 commit comments

Comments
 (0)