Skip to content

docs(update): LegacyJobRetryBehaviorEnabled engine flag #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

docs(update): LegacyJobRetryBehaviorEnabled engine flag #1791

merged 2 commits into from
May 19, 2025

Conversation

venetrius
Copy link
Member

@venetrius venetrius requested a review from yanavasileva May 18, 2025 17:48
@venetrius venetrius self-assigned this May 18, 2025
@venetrius venetrius mentioned this pull request May 18, 2025
Closed
4 tasks
@venetrius
Copy link
Member Author

If I see it correctly we don't list all flags at https://docs.camunda.org/manual/latest/reference/deployment-descriptors/tags/process-engine/.

@yanavasileva
Copy link
Member

If I see it correctly we don't list all flags at

That's true, I just wonder how the customers using 7.23 are going to find information for the new flag. Will the 7.23 migration guide be sufficient?

yanavasileva
yanavasileva reviewed May 19, 2025
View reviewed changes
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so only question above is how customers waiting for the bug fix will understand how to enable the flag. One way is to add a comment in the ticket or the description - how to enable the new behaviour for patch versions.

content/update/minor/723-to-724/_index.md Outdated
- Your process logic may depend on the legacy retry count behavior.
- The legacy behavior avoids loading the full BPMN model and evaluating expressions during job creation, which can improve performance.

In 7.23.2+ the default value is `true` for `legacyJobRetryBehaviorEnabled`. For 7.24.0+ the default value is `false` for `legacyJobRetryBehaviorEnabled`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In 7.23.2+ the default value is `true` for `legacyJobRetryBehaviorEnabled`. For 7.24.0+ the default value is `false` for `legacyJobRetryBehaviorEnabled`
In 7.23.2+ the default value is `true` for `legacyJobRetryBehaviorEnabled`. For 7.24.0+ the default value is `false` for `legacyJobRetryBehaviorEnabled`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

content/update/minor/723-to-724/_index.md Outdated

# LegacyJobRetryBehaviorEnabled process engine flag

Starting with versions 7.23.2 and 7.24.0, the process engine introduces a new configuration flag: `legacyJobRetryBehaviorEnabled`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✍️ Need to add 7.22 patch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks! Updated.

@venetrius
Copy link
Member Author

Looks good so only question above is how customers waiting for the bug fix will understand how to enable the flag. One way is to add a comment in the ticket or the description - how to enable the new behaviour for patch versions.

Added comment: camunda/camunda-bpm-platform#2300 (comment)

@venetrius venetrius requested a review from yanavasileva May 19, 2025 12:37
@venetrius venetrius merged commit e764e48 into master May 19, 2025
1 check passed
@venetrius venetrius deleted the 2300-Job-Executor-getRetries branch May 19, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanavasileva yanavasileva yanavasileva approved these changes

Assignees

@venetrius venetrius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venetrius @yanavasileva