Skip to content

Conversation

HeleneW-dot
Copy link
Contributor

@HeleneW-dot HeleneW-dot commented Mar 24, 2025

related to camunda/camunda-bpm-platform#4962

includes commit from PR#311

Separate PR to try to run CI workflows.
Manual license check done here
Notes on how I did the manual check here

  • Adds a default prometheus-jmx config to avoid error upon starting
  • Adjusts test to grep for jvm_classes_currently_loaded because jvm_info was no longer included in the default metrics response

@HeleneW-dot HeleneW-dot self-assigned this Mar 24, 2025
@HeleneW-dot HeleneW-dot force-pushed the pr-311-bump-jmx_prometheus_javaagent-run-workflows branch from 0defcf7 to 19b7bef Compare March 24, 2025 11:14
@HeleneW-dot HeleneW-dot force-pushed the pr-311-bump-jmx_prometheus_javaagent-run-workflows branch from 19b7bef to e5f3c8c Compare March 24, 2025 11:20
@HeleneW-dot HeleneW-dot force-pushed the pr-311-bump-jmx_prometheus_javaagent-run-workflows branch 2 times, most recently from 0319fbe to a94193a Compare April 2, 2025 08:19
@HeleneW-dot HeleneW-dot requested review from tasso94 and yanavasileva and removed request for tasso94 April 3, 2025 00:55
@HeleneW-dot HeleneW-dot marked this pull request as ready for review April 10, 2025 10:38
HeleneW-dot and others added 2 commits April 10, 2025 17:42
@HeleneW-dot HeleneW-dot force-pushed the pr-311-bump-jmx_prometheus_javaagent-run-workflows branch from a94193a to 7fe8751 Compare April 10, 2025 10:42
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The changes look good to me.

@HeleneW-dot HeleneW-dot merged commit ed866e2 into next Apr 14, 2025
21 checks passed
@HeleneW-dot HeleneW-dot deleted the pr-311-bump-jmx_prometheus_javaagent-run-workflows branch April 14, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants