Skip to content

arrays_beyza_sungar.py #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

arrays_beyza_sungar.py #4

wants to merge 4 commits into from

Conversation

bsungar
Copy link

@bsungar bsungar commented Oct 24, 2023

No description provided.

canbula
canbula requested changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@canbula canbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this homework, we have certain restrictions about the function name and its signature (annotations).

canbula
canbula requested changes Oct 27, 2023
View reviewed changes
Copy link
Owner

@canbula canbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyza, the code block starting with line 17 should be in a if __name__ == "__main__" to prevent its run if someone imports your module. Therefore remove that part or add an if statement at top of it.

canbula
canbula requested changes Oct 28, 2023
View reviewed changes
Copy link
Owner

@canbula canbula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code has failed in a number of tests, you should check the output of the action.

canbula pushed a commit that referenced this pull request Nov 19, 2023
@yaseminkoc
Merge pull request #4 from canbula/master
cf89e7c 
get changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canbula canbula canbula requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsungar @canbula