Skip to content

cli:apply: Ignore udevadm errors triggering devices (LP: #2095203) #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2025
Merged

cli:apply: Ignore udevadm errors triggering devices (LP: #2095203) #539

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ee8637
udevadm: Ignore errors triggering devices
MggMuggins Jan 24, 2025
640bbd8
cli:apply: use single-quotes in logging
slyon Feb 5, 2025
8d1638b
cli:apply: add comment about udevadm trigger errors
slyon Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion netplan_cli/cli/commands/apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,13 @@ def command_apply(self, run_generate=True, sync=False, exit_on_error=True, state
stderr=subprocess.DEVNULL)

subprocess.check_call(['udevadm', 'control', '--reload'])
subprocess.check_call(['udevadm', 'trigger', '--action=move', '--subsystem-match=net', '--settle'])

try:
subprocess.check_call(['udevadm', 'trigger', '--action=move', '--subsystem-match=net', '--settle'])
except subprocess.CalledProcessError as e:
# udevadm trigger returns 1 if it cannot trigger devices since
# systemd v248, e.g. in containers (LP: #2095203)
logging.warning('Ignoring device trigger error: {}'.format(e))

# apply any SR-IOV related changes, if applicable
NetplanApply.process_sriov_config(config_manager, exit_on_error)
Expand Down
Loading