Split generate/configure stages for sd-generator compliance #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
slyon
force-pushed
the
generator-split-sd-1997
branch
8 times, most recently
from
8287a28 to
9105838
Compare
slyon
force-pushed
the
generator-split-sd-1997
branch
2 times, most recently
from
15db9ad to
320629c
Compare
|
FIXME: call |
slyon
force-pushed
the
generator-split-sd-1997
branch
from
320629c to
4f36a61
Compare
This is initally a copy of generate.c.
./generate being the systemd-generator in /usr/lib/systemd/system-generators/ producing systemd service units exclusively ./configure being a normal Netplan service binary, producing backend configs (e.g. for NM, sd-networkd, udev, ...)
…/configure Run using: LD_LIBRARY_PATH=_build/src NETPLAN_DBUS_CMD=_build/dbus/netplan-dbus NETPLAN_GENERATE_PATH=$(pwd)/_build/src/generate G_DEBUG=fatal_criticals PYTHONPATH=_build/python-cffi:. pytest -s -v tests/generator/test_sd-generator.py
slyon
force-pushed
the
generator-split-sd-1997
branch
from
4f36a61 to
6e4c640
Compare
slyon
force-pushed
the
generator-split-sd-1997
branch
3 times, most recently
from
87ff9b8 to
b507c0d
Compare
slyon
force-pushed
the
generator-split-sd-1997
branch
from
b507c0d to
d2bd8a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spec: FO165 – Netplan generator architecture
Initial testing of systemd sandbox:
Checklist
make checksuccessfully.make check-coverage).This should also fix https://bugs.launchpad.net/ubuntu/+source/network-manager/+bug/2083129 by not re-generating NM configuration on the fly.