Fail cleanly when systemd-networkd is not installed

netplan_cli/cli/state.py

@@ -433,6 +433,9 @@ def __init__(self, ifname=None, all=False):
                               'but systemd-networkd.service is masked. '
                               'Please start it.')
                 sys.exit(1)
+            if not utils.systemctl_is_installed('systemd-networkd.service'):
+                logging.error('systemd-networkd is required for \'netplan status\' functionality')
+                sys.exit(1)
             logging.debug('systemd-networkd.service is not active. Starting...')
             utils.systemctl('start', ['systemd-networkd.service'], True)
 

netplan_cli/cli/utils.py

@@ -156,7 +156,7 @@ def systemctl_is_masked(unit_pattern):
 
 def systemctl_is_installed(unit_pattern):
     '''Return True if returncode is other than "not-found" (4)'''
-    res = subprocess.run(['systemctl', 'is-enabled', unit_pattern],
+    res = subprocess.run(['systemctl', 'status', unit_pattern],
                          stdout=subprocess.PIPE, stderr=subprocess.PIPE,
                          text=True)
     if res.returncode != 4:

tests/cli/test_status.py

@@ -531,6 +531,18 @@ def test_call_cli_networkd_masked(self, is_masked_mock, is_active_mock):
         self.assertEqual(1, e.exception.code)
         self.assertIn('systemd-networkd.service is masked', cm.output[0])
 
+    @patch('netplan_cli.cli.utils.systemctl_is_installed')
+    @patch('netplan_cli.cli.utils.systemctl_is_active')
+    @patch('netplan_cli.cli.utils.systemctl_is_masked')
+    def test_call_cli_networkd_installed_false(self, is_installed_mock, is_active_mock, is_masked_mock):
+        is_active_mock.return_value = False
+        is_masked_mock.return_value = False
+        is_installed_mock.return_value = False
+        with self.assertLogs() as cm, self.assertRaises(SystemExit) as e:
+            self._call([])
+        self.assertEqual(1, e.exception.code)
+        self.assertIn('systemd-networkd is required for \'netplan status\' functionality', cm.output[0])
+
     @patch('netplan_cli.cli.state.NetplanConfigState.__init__')
     @patch('netplan_cli.cli.state_diff.NetplanDiffState.__init__')
     @patch('netplan_cli.cli.state_diff.NetplanDiffState.get_diff')

tests/test_utils.py

@@ -402,7 +402,7 @@ def test_systemctl_is_installed(self):
         os.environ['PATH'] = os.path.dirname(self.mock_cmd.path) + os.pathsep + path_env
         self.assertTrue(utils.systemctl_is_installed('some.service'))
         self.assertEqual(self.mock_cmd.calls(), [
-            ['systemctl', 'is-enabled', 'some.service']
+            ['systemctl', 'status', 'some.service']
         ])
 
     def test_systemctl_is_installed_false(self):
@@ -412,7 +412,7 @@ def test_systemctl_is_installed_false(self):
         os.environ['PATH'] = os.path.dirname(self.mock_cmd.path) + os.pathsep + path_env
         self.assertFalse(utils.systemctl_is_installed('some.service'))
         self.assertEqual(self.mock_cmd.calls(), [
-            ['systemctl', 'is-enabled', 'some.service']
+            ['systemctl', 'status', 'some.service']
         ])
 
     def test_systemctl_daemon_reload(self):