-
Notifications
You must be signed in to change notification settings - Fork 972
Update install and use instructions for cardano-node #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install and use instructions for cardano-node #1453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one..
Left some comments (sorry those may not necessarily be relevant within scope of this PR, but since they're touched - we might as well update things like disk space usage from node 🙂 )
Also, unless intentional - I believe the lock files shouldnt be checked in on documentation updates (perhaps check-in via #1451 makes more sense instead)?
aa0384f
to
cf6aa81
Compare
I re-submitted this PR without the update to docusaurus. Unfortunately I cannot test it locally anymore so I hope it works fine. I adressed the comments above. |
cf6aa81
to
0d47db2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasagredo this is going to save SPOs and builders a lot of trouble in the days ahead. ⭐ Thanks for factoring out the Docusaurus while we get a consensus how to handle that. I tested the branch locally with
git fetch upstream pull/1453/head:v-1453
git checkout v-1453
and it builds properly, looks and works fine. The style sheet change for the tabs looks good to me & I think is a general improvement in case it cascades into the rest of the site. All changes I recall from @rdlrt's review are also here as far as I can tell. Thanks for all the extra work on this beyond the initial submission. 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Checklist
yarn build
after adding my changes without getting any errors.yarn.lock
(or have removed these changes).Updating documentation or Bugfix
I updated the steps for building the node:
cardano-cli
not living incardano-node
repository.db
entirely they will have to sync from scratch.Also for the running example I updated the output with that of a recent cardano-node.
This PR is based on #1451, so reviewing is probably best done by seeing only the changes in the last commit, plus disabling whitespace changes.
If wanted I could merge this one without the other one, but I needed it in order to have a local web server for previews.