-
Notifications
You must be signed in to change notification settings - Fork 318
feat: use GoogleCompletionRequest.systemInstruction for system prompt #989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use GoogleCompletionRequest.systemInstruction for system prompt #989
Conversation
Since I havent been following the development of this plugin the past months, I am not sure but I am guessing up until now thought tokens of reasoning models are also just printed to the user in the chat panel etc, right? |
IIRC the thinking output is never displayed. At least when I initially introduced the Gemini thinking models, the support wasn't there yet (or was intentionally removed or something). |
Can you release |
e7dc4f3
to
8de410f
Compare
Solved the conflicts |
…#989) * feat: use GoogleCompletionRequest.systemInstruction for system prompt * fix(test): req body assertion --------- Co-authored-by: Carl-Robert Linnupuu <carlrobertoh@gmail.com>
…#989) * feat: use GoogleCompletionRequest.systemInstruction for system prompt * fix(test): req body assertion --------- Co-authored-by: Carl-Robert Linnupuu <carlrobertoh@gmail.com>
Depends on carlrobertoh/llm-client#61
systemInstruction
field for system prompts