-
-
Notifications
You must be signed in to change notification settings - Fork 76
Switch code review PR target to be develop branch rather than main #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/python-intermediate-development/compare/md-outputs..md-outputs-PR-464 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2025-05-30 16:09:29 +0000 |
Auto-generated via `{sandpaper}`
Source : af1c687
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-06-19 08:54:39 +0000
Message : Merge pull request #464 from carpentries-incubator/bielsnohr/code-review-branch-target
Switch code review PR target to be develop branch rather than main
Auto-generated via `{sandpaper}`
Source : 530e29a
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-19 08:55:22 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : af1c687
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-06-19 08:54:39 +0000
Message : Merge pull request #464 from carpentries-incubator/bielsnohr/code-review-branch-target
Switch code review PR target to be develop branch rather than main
Auto-generated via `{sandpaper}`
Source : 530e29a
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-19 08:55:22 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : af1c687
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-06-19 08:54:39 +0000
Message : Merge pull request #464 from carpentries-incubator/bielsnohr/code-review-branch-target
Switch code review PR target to be develop branch rather than main
Auto-generated via `{sandpaper}`
Source : 530e29a
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-19 08:55:22 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : af1c687
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-06-19 08:54:39 +0000
Message : Merge pull request #464 from carpentries-incubator/bielsnohr/code-review-branch-target
Switch code review PR target to be develop branch rather than main
Auto-generated via `{sandpaper}`
Source : 530e29a
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-19 08:55:22 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : af1c687
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-06-19 08:54:39 +0000
Message : Merge pull request #464 from carpentries-incubator/bielsnohr/code-review-branch-target
Switch code review PR target to be develop branch rather than main
Auto-generated via `{sandpaper}`
Source : 530e29a
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-19 08:55:22 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : af1c687
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-06-19 08:54:39 +0000
Message : Merge pull request #464 from carpentries-incubator/bielsnohr/code-review-branch-target
Switch code review PR target to be develop branch rather than main
Auto-generated via `{sandpaper}`
Source : 530e29a
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2025-06-19 08:55:22 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : af1c687
Branch : main
Author : Aleksandra Nenadic <a.nenadic@manchester.ac.uk>
Time : 2025-06-19 08:54:39 +0000
Message : Merge pull request #464 from carpentries-incubator/bielsnohr/code-review-branch-target
Switch code review PR target to be develop branch rather than main
In the "Raising a Pull Request" section of Episode 4.1, the target branch for the PR is set to be
main. If we are following "gitflow" like in the rest of the lesson, this should bedevelop. This has directly caused confusion in our runs of the course and I don't think it should cause any issues, although there might be some merge conflicts because thedevelopbranch has had quite a bit done to it by this point, and thefeature-std-devbranch is quite far behind.I will report back how it goes, but if someone is able to resolve this more immediately, that would be appreciated.
Resolves #458