Fix null property error, remove created date filters

Author: karadietz

service/src/main/kotlin/app/cash/backfila/dashboard/GetBackfillRunsAction.kt

@@ -60,14 +60,10 @@ class GetBackfillRunsAction @Inject constructor(
     @QueryParam pagination_token: String? = null,
     @QueryParam backfill_name: String? = null,
     @QueryParam created_by_user: String? = null,
-    @QueryParam created_start_date: Instant? = null,
-    @QueryParam created_end_date: Instant? = null,
   ): GetBackfillRunsResponse {
     val filterArgs = FilterArgs(
       backfillName = backfill_name,
       createdByUser = created_by_user,
-      createdStartDate = created_start_date,
-      createdEndDate = created_end_date,
     )
     return search(service, variant, pagination_token, filterArgs)
   }
@@ -214,33 +210,13 @@ class GetBackfillRunsAction @Inject constructor(
     }
   }
 
-  private fun BackfillRunQuery.filterByStartDate(startDate: Instant?): BackfillRunQuery {
-    return if (startDate == null) {
-      this
-    } else {
-      this.createdAfter(startDate)
-    }
-  }
-
-  private fun BackfillRunQuery.filterByEndDate(endDate: Instant?): BackfillRunQuery {
-    return if (endDate == null) {
-      this
-    } else {
-      this.createdBefore(endDate)
-    }
-  }
-
   private fun BackfillRunQuery.filterByArgs(filterArgs: FilterArgs): BackfillRunQuery {
     return this.filterByUserCreatedIfPresent(filterArgs.createdByUser)
       .filterByBackfillNameIfPresent(filterArgs.backfillName)
-      .filterByStartDate(filterArgs.createdStartDate)
-      .filterByEndDate(filterArgs.createdEndDate)
   }
 
   private data class FilterArgs(
     val backfillName: String? = null,
     val createdByUser: String? = null,
-    val createdStartDate: Instant? = null,
-    val createdEndDate: Instant? = null,
   )
 }

service/src/test/kotlin/app/cash/backfila/actions/GetBackfillRunsActionFilteredTest.kt

@@ -16,7 +16,6 @@ import app.cash.backfila.protos.service.CreateBackfillRequest
 import app.cash.backfila.service.persistence.BackfilaDb
 import app.cash.backfila.service.persistence.RegisteredBackfillQuery
 import com.google.inject.Module
-import java.time.Duration
 import javax.inject.Inject
 import misk.hibernate.Query
 import misk.hibernate.Transacter
@@ -220,71 +219,6 @@ class GetBackfillRunsActionFilteredTest {
     }
   }
 
-  @Test
-  fun `search by date`() {
-    scope.fakeCaller(user = "molly") {
-      val backfillStartTime1 = clock.instant()
-
-      createBackfillAction.create(
-        "deep-fryer",
-        ConfigureServiceAction.RESERVED_VARIANT,
-        CreateBackfillRequest.Builder()
-          .backfill_name("ChickenSandwich")
-          .build(),
-      )
-
-      clock.add(Duration.ofDays(1))
-      val backfillStartTime2 = clock.instant()
-      createBackfillAction.create(
-        "deep-fryer",
-        ConfigureServiceAction.RESERVED_VARIANT,
-        CreateBackfillRequest.Builder()
-          .backfill_name("FrenchFries")
-          .build(),
-      )
-      createBackfillAction.create(
-        "deep-fryer",
-        ConfigureServiceAction.RESERVED_VARIANT,
-        CreateBackfillRequest.Builder()
-          .backfill_name("FrenchFries")
-          .build(),
-      )
-      var backfillSearchResults = getBackfillRunsAction.backfillRuns(
-        service = "deep-fryer",
-        variant = RESERVED_VARIANT,
-        pagination_token = null,
-        created_start_date = backfillStartTime1,
-        created_end_date = backfillStartTime1.plus(Duration.ofSeconds(1)),
-      )
-      assertThat(backfillSearchResults.paused_backfills).hasSize(1)
-
-      backfillSearchResults = getBackfillRunsAction.backfillRuns(
-        service = "deep-fryer",
-        variant = RESERVED_VARIANT,
-        pagination_token = null,
-        created_start_date = backfillStartTime1 + Duration.ofSeconds(1),
-        created_end_date = backfillStartTime2,
-      )
-      assertThat(backfillSearchResults.paused_backfills).hasSize(2)
-
-      backfillSearchResults = getBackfillRunsAction.backfillRuns(
-        service = "deep-fryer",
-        variant = RESERVED_VARIANT,
-        pagination_token = null,
-        created_start_date = backfillStartTime1,
-      )
-      assertThat(backfillSearchResults.paused_backfills).hasSize(3)
-
-      backfillSearchResults = getBackfillRunsAction.backfillRuns(
-        service = "deep-fryer",
-        variant = RESERVED_VARIANT,
-        pagination_token = null,
-        created_end_date = backfillStartTime1,
-      )
-      assertThat(backfillSearchResults.paused_backfills).hasSize(1)
-    }
-  }
-
   @Test
   fun `multiple criteria search`() {
     scope.fakeCaller(user = "diana") {

service/web/tabs/app/src/containers/ServiceDetailsContainer.tsx

@@ -26,6 +26,8 @@ import { Link } from "react-router-dom"
 import { LayoutContainer } from "."
 import { RESERVED_VARIANT } from "../utilities"
 
+type IProps = IState & IDispatchProps
+
 interface BackfillSearchState {
   loading: boolean
   errorText?: string
@@ -36,27 +38,30 @@ interface BackfillSearchState {
 
 class ServiceDetailsContainer extends React.Component<
   IState & IDispatchProps,
-  IState & BackfillSearchState
+  BackfillSearchState
 > {
   private service: string = (this.props as any).match.params.service
   private variant: string =
     (this.props as any).match.params.variant ?? RESERVED_VARIANT
   private backfillRunsTag: string = `${this.service}::${this.variant}::BackfillRuns`
   private registeredBackfills: string = `${this.service}::BackfillRuns`
 
+  constructor(props: IProps) {
+    super(props)
+    this.state = {
+      loading: false,
+      errorText: null,
+      backfillName: null,
+      createdBy: null
+    }
+  }
+
   componentDidMount() {
     this.props.simpleNetworkGet(
       this.registeredBackfills,
       `/services/${this.service}/variants/${this.variant}/registered-backfills`
     )
 
-    this.setState({
-      loading: false,
-      errorText: null,
-      backfillName: null,
-      createdBy: null
-    })
-
     this.fetchBackfillRuns()
   }