Skip to content

Commit fc94216

Browse files
committed
Don't show duplicate /variant on service index, rely on tag for variant
1 parent c11cffd commit fc94216

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

service/src/main/kotlin/app/cash/backfila/ui/actions/BackfillCreateHandlerAction.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ package app.cash.backfila.ui.actions
33
import app.cash.backfila.dashboard.CreateBackfillAction
44
import app.cash.backfila.protos.service.CreateBackfillRequest
55
import app.cash.backfila.ui.pages.BackfillCreateAction.BackfillCreateField
6+
import javax.inject.Inject
7+
import javax.inject.Singleton
68
import misk.scope.ActionScoped
79
import misk.security.authz.Authenticated
810
import misk.web.Get
@@ -15,8 +17,6 @@ import misk.web.mediatype.MediaTypes
1517
import misk.web.toResponseBody
1618
import okhttp3.Headers
1719
import okio.ByteString.Companion.encodeUtf8
18-
import javax.inject.Inject
19-
import javax.inject.Singleton
2020

2121
@Singleton
2222
class BackfillCreateHandlerAction @Inject constructor(

service/src/main/kotlin/app/cash/backfila/ui/components/ServiceSelection.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,10 @@ fun TagConsumer<*>.ServiceSelect(
4444
div("flex w-full items-center justify-between space-x-6 p-6") {
4545
div("flex-1 truncate") {
4646
div("flex items-center space-x-3") {
47-
// Don't include default variant in label, only for unique variants
48-
val label = if (variant == null) service.name else servicePath
4947
h3("truncate text-sm font-medium text-gray-900") {
50-
+"""$label (${service.running_backfills})"""
48+
+"""${service.name} (${service.running_backfills})"""
5149
}
50+
// Don't include default variant in label, only for unique variants
5251
variant?.let { span("inline-flex shrink-0 items-center rounded-full bg-green-50 px-1.5 py-0.5 text-xs font-medium text-green-700 ring-1 ring-inset ring-green-600/20") { +it } }
5352
}
5453
// p("mt-1 truncate text-sm text-gray-500") { +"""Regional Paradigm Technician""" }

0 commit comments

Comments
 (0)