Skip to content

Use h2c when configuring gRPC clients with http:// URLs #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Use h2c when configuring gRPC clients with http:// URLs #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions service/src/main/kotlin/app/cash/backfila/client/GrpcCallbackConnectorProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import misk.client.HttpClientConfigUrlProvider
import misk.client.HttpClientFactory
import misk.client.HttpClientsConfig
import misk.moshi.adapter
import okhttp3.Protocol

@Singleton
class GrpcCallbackConnectorProvider @Inject constructor(
Expand Down Expand Up @@ -49,16 +50,22 @@ class GrpcCallbackConnectorProvider @Inject constructor(
val headers: List<HttpHeader>? = extraData!!.headers

val httpClientEndpointConfig = httpClientsConfig[url]
var okHttpClient = httpClientFactory.create(httpClientEndpointConfig)
val baseUrl = httpClientConfigUrlProvider.getUrl(httpClientEndpointConfig)

val okHttpClientBuilder = httpClientFactory.create(httpClientEndpointConfig).newBuilder()
if (!headers.isNullOrEmpty()) {
okHttpClient = okHttpClient.newBuilder()
.addInterceptor(OkHttpClientSpecifiedHeadersInterceptor(headers))
.build()
okHttpClientBuilder.addInterceptor(OkHttpClientSpecifiedHeadersInterceptor(headers))
}

// Since gRPC uses HTTP/2, force h2c when calling an unencrypted endpoint
if (baseUrl.startsWith("http://")) {
okHttpClientBuilder.protocols(listOf(Protocol.H2_PRIOR_KNOWLEDGE))
} else {
okHttpClientBuilder.protocols(listOf(Protocol.HTTP_2, Protocol.HTTP_1_1))
}

val baseUrl = httpClientConfigUrlProvider.getUrl(httpClientEndpointConfig)
val grpcClient = GrpcClient.Builder()
.client(okHttpClient)
.client(okHttpClientBuilder.build())
.baseUrl(baseUrl)
.build()
val api = grpcClient.create(BackfilaClientServiceClient::class)
Expand Down
Loading