Skip to content

Conversation

DianaFaire
Copy link
Contributor

@DianaFaire DianaFaire commented Feb 21, 2025

Add ability to search/filter past backfills on a service by name and author.

Before filtering by backfill name:
image
After filtering by backfill name:
image

@karadietz
Copy link
Contributor

Demo using the search filters:
(note that I decreased the page size for the demo from 20 to 5 to show pagination still works)

demo_backfila_search_filters.mov

Demo showing that you can search for inactive backfills:

demo_search_for_inactive_backfill.mov

@mpawliszyn
Copy link
Collaborator

I wish you had said something earlier as we are migrating to a new UI:
https://github.com/cashapp/backfila/pull/420/files
Should hopefully make this kind of change easier.

@DianaFaire DianaFaire marked this pull request as ready for review February 25, 2025 20:03
@adrw
Copy link
Collaborator

adrw commented Feb 28, 2025

Thanks for this contribution! We are moving to a new UI so you're welcome to add a contribution there or we can try and add support as we work through the remaining missing functionality to reach parity with the existing UI. #407

Copy link
Collaborator

@mpawliszyn mpawliszyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned this will be removed with the UI update but otherwise it is a welcome change.

@mpawliszyn
Copy link
Collaborator

I'll merge this for now though.

@mpawliszyn mpawliszyn merged commit 538d161 into cashapp:master Mar 5, 2025
4 checks passed
@karadietz
Copy link
Contributor

@mpawliszyn thanks! I can look into adding this functionality to the new UI as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants