Show error in UI when update field fails #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrw
force-pushed
the
2025-04-09.errorMessageFieldUpdate
branch
from
a476913 to
2aae95c
Compare
Bump Misk 2025.04.09.202256-90dc722 which fixes old Backfila UI failing on missing web assets
adrw
force-pushed
the
2025-04-09.errorMessageFieldUpdate
branch
from
2aae95c to
93d0338
Compare
sq-js
reviewed
Apr 9, 2025
| } | ||
| return Response( | ||
| body = errorHtmlResponseBody, | ||
| statusCode = 200, |
There was a problem hiding this comment.
statusCode 200 for an exception? 🤔
There was a problem hiding this comment.
Yes because this endpoint is only serving browser traffic
sq-js
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump Misk 2025.04.09.202256-90dc722 which fixes old Backfila UI failing
on missing web assets