Add three range logic to new form - Restart, continue and new #432
+167
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhwang-sq
changed the title
adrw
reviewed
Apr 16, 2025
service/src/main/kotlin/app/cash/backfila/ui/actions/BackfillCreateHandlerAction.kt
Outdated
Show resolved
Hide resolved
adrw
reviewed
Apr 21, 2025
service/src/main/kotlin/app/cash/backfila/ui/actions/BackfillCreateHandlerAction.kt
Outdated
Show resolved
Hide resolved
mpawliszyn
reviewed
Apr 21, 2025
| +"""Range Start (optional)""" | ||
| } | ||
| div("mt-2") { | ||
| input(classes = "block w-full rounded-md bg-white px-3 py-1.5 text-base text-gray-900 outline outline-1 -outline-offset-1 outline-gray-300 placeholder:text-gray-400 focus:outline focus:outline-2 focus:-outline-offset-2 focus:outline-indigo-600 sm:text-sm/6") { |
There was a problem hiding this comment.
@adrw Are there good ways to handle all this copy and paste? I wonder if we should be doing something about this or not?
mpawliszyn
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for clone (create stays the same) -
CONTINUE - use cursor if available, failing back to start position
RESTART - use original start position
NEW - use form values (this is what we only had)
Screen.Recording.2025-04-16.at.3.57.12.PM.mov